fix(connectors): use model-safe tool input names - #338
Merged
Merged
Conversation
tangletools
approved these changes
Oct 1, 2026
tangletools
left a comment
Collaborator
There was a problem hiding this comment.
✅ Auto-approved PR — f3c7afee
Blanket team auto-approval is intentional. The merge gates are CI and codex-p1.
No automated review runs on this PR. This approval rests on the rule above alone.
tangletools · auto-approval · reason: blanket_auto_approve · 2026-10-01T07:53:33Z
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Anthropic rejected a default canary before generation because a Hub MCP tool schema contained a property name outside
^[a-zA-Z0-9_.-]{1,64}$(tools.143.custom.input_schema.properties). The trace does not contain the outbound tool array, so the exact ordinal remains unproven. The published 0.59.1 bundled manifest contains 50 invalid property names across 17 capabilities in nine connectors.Change
Use model-safe input names for the affected connector capabilities. Keep Microsoft Graph
$OData query keys and Mailgun/Trello provider fields in the outgoing requests. Regenerate the 634-manifest snapshot. Add a regression gate over bundled manifests and Hub-facing spec actions, plus adapter invocation checks for every affected capability.Verification
pnpm run generate:bundled-manifestspassed.pnpm typecheckpassed.pnpm run check:bundled-manifest-freshnesspassed (634 manifests).pnpm testpassed (3,213 tests, 486 files).dist/specs.jsexposesmicrosoft-calendar.list_eventswithcalendarId, top, skip, filter, select, orderBy, search; 2,484 Hub spec actions have no invalid top-level property names.Review note
The public input names change for 17 capabilities. No checked-in direct caller of the old invalid names was found. The adapter tests verify the corresponding provider request keys remain in place. Please review the Trello body mapping and Microsoft Calendar direct invocation in particular. This PR does not publish npm or promote ADC.