Skip to content

fix(connectors): use model-safe tool input names - #338

Merged
drewstone merged 1 commit into
mainfrom
fix/model-safe-connector-schemas
Oct 1, 2026
Merged

drewstone merged 1 commit into
mainfrom
fix/model-safe-connector-schemas

Conversation

@drewstone

Copy link
Copy Markdown
Contributor

Problem

Anthropic rejected a default canary before generation because a Hub MCP tool schema contained a property name outside ^[a-zA-Z0-9_.-]{1,64}$ (tools.143.custom.input_schema.properties). The trace does not contain the outbound tool array, so the exact ordinal remains unproven. The published 0.59.1 bundled manifest contains 50 invalid property names across 17 capabilities in nine connectors.

Change

Use model-safe input names for the affected connector capabilities. Keep Microsoft Graph $ OData query keys and Mailgun/Trello provider fields in the outgoing requests. Regenerate the 634-manifest snapshot. Add a regression gate over bundled manifests and Hub-facing spec actions, plus adapter invocation checks for every affected capability.

Verification

  • pnpm run generate:bundled-manifests passed.
  • pnpm typecheck passed.
  • pnpm run check:bundled-manifest-freshness passed (634 manifests).
  • pnpm test passed (3,213 tests, 486 files).
  • Built dist/specs.js exposes microsoft-calendar.list_events with calendarId, top, skip, filter, select, orderBy, search; 2,484 Hub spec actions have no invalid top-level property names.

Review note

The public input names change for 17 capabilities. No checked-in direct caller of the old invalid names was found. The adapter tests verify the corresponding provider request keys remain in place. Please review the Trello body mapping and Microsoft Calendar direct invocation in particular. This PR does not publish npm or promote ADC.

@tangletools tangletools left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Auto-approved PR — f3c7afee

Blanket team auto-approval is intentional. The merge gates are CI and codex-p1.
No automated review runs on this PR. This approval rests on the rule above alone.

tangletools · auto-approval · reason: blanket_auto_approve · 2026-10-01T07:53:33Z

@drewstone
drewstone merged commit 9893b2e into main Oct 1, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants