Repository navigation
fix: update ldk node for lightning security fixes - #928
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cf8a4b6c5e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Closing: |
|
Reopened: this keeps |
talosmachina
left a comment
There was a problem hiding this comment.
No findings. This bumps LDK Node from 0.7.0-rc.71 to 0.7.0-rc.72 (the lightning 0.2.7 security fixes) in the SwiftPM requirement and in Package.resolved. Reviewed c8666a8, full tier because it changes a dependency pin.
What I checked, and 3 candidates I ruled out
Read in full: the three changed files, plus Package.swift at v0.7.0-rc.72
Not built here: iOS does not build on Linux. The gates are unit-tests and integration-tests, both still running on this head.
CI: an earlier e2e-tests run on this head was cancelled before its shards ran, and its e2e-status job reports that as a failure. A fresh e2e-tests run is in progress, so the red e2e-status comes from the cancellation, not from this change.
Ruled out
- rc.72 carries more than the dependency bump:
git diff v0.7.0-rc.71 v0.7.0-rc.72insynonymdev/ldk-nodetouches 7 files only:Cargo.toml(lightning,lightning-liquidity,lightning-transaction-syncto0.2.7, crate version),Cargo.lock(those three crates: 0.2.5, 0.2.3 and 0.2.1 to 0.2.7),Package.swift, the two Kotlingradle.properties,pyproject.tomlandCHANGELOG.md. The merge commit of #122 in the range adds no content on top of rc.71. Nosrc/, UDL or generated binding changed, so the app-facing API is the same as rc.71. - Stale pins left behind: the only other
rc.71strings in the branch are injourneys/pubky-marketplace/local-paykit-fallback.md, which is documentation. - Pinned revision or binary does not match the release:
Package.resolvedpinsd1bd9fcc9ceb11849323f4aaf21d32eb95b15c02, which is whatrefs/tags/v0.7.0-rc.72points to. TheLDKNodeFFI.xcframework.ziprelease asset hashes toc9e93929…d54a1c, the checksumPackage.swiftdeclares at that tag.
Merge confidence: 4/5. Nothing found, but this upgrades the Lightning node and only the e2e run exercises it; that run and the unit and integration tests had not finished when I reviewed.
|
Pushed fad3913: the release note is now the fragment |
Twin: synonymdev/bitkit-android#1475
Refs: synonymdev/ldk-node#123
Description
0.7.0-rc.71to0.7.0-rc.72onmaster, so the shipped node picks up thelightning,lightning-liquidityandlightning-transaction-sync0.2.7 security fixes. It reachesrelease-2.6.0whenmasteris merged in.0.7.0-rc.72is rc.71 with only those three dependencies updated (release).Design
N/A — no UI changes.
Preview
N/A — no user-visible changes.
QA Notes
Manual Tests
Automated Checks
xcodebuild -resolvePackageDependenciesresolvesldk-nodeat0.7.0-rc.72;Package.resolvedpins the release tag's commit.