Skip to content

chore: bump version 2.5.1 - #924

Closed
piotr-iohk wants to merge 5 commits into
masterfrom
release-2.5.1
Closed

piotr-iohk wants to merge 5 commits into
masterfrom
release-2.5.1

Conversation

@piotr-iohk

@piotr-iohk piotr-iohk commented Oct 13, 2026 •

Copy link
Copy Markdown
Collaborator

Prepare Bitkit 2.5.1 (build 198) from v2.5.0 with LDK Node 0.7.0-rc.66.1 for upstream Lightning security fixes.

Description

  • Set version 2.5.1 and build 198.
  • Update LDK Node from rc.66 to rc.66.1.
  • Finalize the dated 2.5.1 changelog and comparison links.
  • Keep this hotfix based on v2.5.0. Close this PR after the store release; do not merge it into master. The equivalent LDK security update reaches master and 2.6.0 separately through rc.72. Preserve the release branch and v2.5.1 tag as the shipped hotfix history.

Design

N/A — no UI changes.

Preview

N/A

QA Notes

Journeys

Existing Lightning payment and wallet recovery journeys apply.

Manual Tests

Release runtime validation remains pending.

Automated Checks

Version metadata and changelog structure verified; diff whitespace checks passed. Branch-dispatched CI and regular E2E will be linked in a follow-up comment. E2E uses release-2.5.1 in the test repo, initially identical to tag 2.5.0. Migration is deferred.

@ovitrif ovitrif added this to the 2.5.1 milestone Oct 13, 2026
@piotr-iohk

Copy link
Copy Markdown
Collaborator Author

2.5.1 release preparation is finalized for validation at 0db76166fc135f618998c84e65f477d8c10e12d2 (tag v2.5.1): dated changelog, comparison links, draft GitHub release and translated local store notes are prepared. LDK Node is 0.7.0-rc.66.1.

Dispatched checks on this exact revision:

Both E2E workflows successfully resolved e2e_branch=release-2.5.1. The E2E branch points to 2856050ef62493a187e506970a3f88f611db8803, exactly tag 2.5.0. These are branch-dispatched checks, avoiding the conflicting merge into master. Migration has not been dispatched. Results are pending; this is not release sign-off.

iOS archive/TestFlight upload will be performed manually in Xcode (2.5.1 build 198). The shared migration wallet-setup reference remains @main after the requested revert.

@piotr-iohk
piotr-iohk marked this pull request as ready for review October 13, 2026 15:19
@piotr-iohk
piotr-iohk requested a review from ovitrif October 13, 2026 15:19
@ovi-reviewer

ovi-reviewer Bot commented Oct 13, 2026

Copy link
Copy Markdown

@piotr-iohk conflicts

@greptile-apps

greptile-apps Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

[High impact] No blocking code issue was found; keep this hotfix out of master as requested.

Summary

Prepares Bitkit 2.5.1, build 198, from the 2.5.0 release.

  • Bitkit's Lightning wallet uses LDK Node 0.7.0-rc.66.1.
  • Bitkit's release settings and changelog identify version 2.5.1.

Reviews (1) · Last reviewed commit: "chore: finalize 2.5.1 release changelog" · Reviewed by Greptile

@talosmachina talosmachina left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No findings. Hotfix 2.5.1 off v2.5.0: MARKETING_VERSION 2.5.1 and CURRENT_PROJECT_VERSION 198 on all six app, widget and notification configs, LDK Node exact pin 0.7.0-rc.66 to 0.7.0-rc.66.1, dated changelog. Reviewed 0db7616, full tier (dependency manifest), reasoned from the code and CI; iOS does not build on this box.

What I checked, and 3 candidates I ruled out

Read: the project.pbxproj hunks, Package.resolved, CHANGELOG.md
CI on the head: unit-tests and integration-tests green; e2e-tests still running when this was posted. The ovi-reviewer check is not tied to this diff.

Ruled out

  • A missed target: every config that carried 2.5.0/197 now carries 2.5.1/198; the remaining 1.0/1 entries are the test targets, unchanged on master too.
  • Pin and lockfile disagree: Package.resolved revision 0692193 is exactly what ldk-node tag v0.7.0-rc.66.1 points at, and that release carries the LDKNodeFFI.xcframework.zip its Package.swift downloads.
  • The CI pin commit: 4889cab is reverted by 61f482a, so it nets to nothing in the diff.

Merge confidence: 4/5, e2e had not finished on this head when reviewed; unit and integration are green.

@ovitrif ovitrif left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: ♻️ Comment

Review: diff 3 files.

Comment only, so this PR cannot be merged by accident: it is to be closed after the 2.5.1 store release, never merged into master. The LDK update reaches master through #928.

Findings:
N/A

  • release-2.5.1 differs from v2.5.0 only in build 198, version 2.5.1, LDK Node 0.7.0-rc.66.1 and the dated 2.5.1 changelog.
  • Package.resolved pins 0.7.0-rc.66.1 at 0692193, the tagged release commit, and its LDKNodeFFI.xcframework.zip matches the Package.swift checksum.
  • 0.7.0-rc.66.1 is the rc.66 source with only lightning, lightning-liquidity and lightning-transaction-sync at 0.2.7.

Reviewed by claude-opus-5-5 via gh-pr-review-loop skill

@jvsena42 jvsena42 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No findings at 0db7616, reviewed against v2.5.0 (the tag this hotfix is cut from). The merge conflicts with master are expected, since this branch closes after the store release instead of merging. I'm posting this as a comment rather than an approval so it can't be merged by accident.

Checked and clean:

  • Diff v2.5.0..0db7616: three files. MARKETING_VERSION 2.5.1 and build 198 on all six app, widget and notification configurations. ldk-node 0.7.0-rc.66 → 0.7.0-rc.66.1 in both project.pbxproj and Package.resolved. The dated [2.5.1] changelog section and links. 4889cab is reverted by 61f482a, so it nets to nothing.
  • ldk-node v0.7.0-rc.66...v0.7.0-rc.66.1: 3 commits. The only Cargo.toml changes are the version and lightning, lightning-liquidity and lightning-transaction-sync 0.2.0 → 0.2.7, plus a committed Cargo.lock and rebuilt binaries. The tag resolves to 0692193, the pinned revision. Android v2.5.1 pins the same 0.7.0-rc.66.1.
  • CI at 0db7616: the dispatched unit, integration and e2e runs are green. E2E Migration was never run at this head (its only run, on 51ad7d1, was skipped), so I ran the upgrade by hand, below.

Device gate: 0db7616 — 2.5.0 → 2.5.1 upgrade on the iPhone 17 simulator (iOS 26.5), regtest staging: 1 passed; perf: not relevant; Figma: n/a; Android: v2.5.1 already published with the same LDK Node.

  • On v2.5.0 (build 197): new wallet, 300 000 sats received on-chain, then Transfer to Spending of 100 000. The channel became ready at 13:21:14 UTC. Savings 197 422, Spending 100 000.
  • This head (build 198) installed over it: savings, spending and activity unchanged. The node started at 13:21:51 and reconnected to the LSP with channel_reestablish.
  • After the upgrade: received a 5 000-sat Lightning payment over the pre-upgrade channel, and Spending went to 105 000:
    13:21:51.910 INFO  Node started [LightningService.swift: start(onEvent:) line: 276]
    13:21:52.571 INFO  Connected to peer 028a8910…69fc@34.65.86.104:9400.  - [LDK] [ldk_node:1298]
    13:23:45.784 DEBUG Handling event PaymentClaimed { receiver_node_id: Some(…), payment_hash: 26e21c31… }
    
  • Log noise: the "Background sync of RGS gossip data failed" error also appears on v2.5.0 against staging, so it is not a regression. "Node is not setup" and "balances is nil" appear only during startup, before the node started.

⚠️ Not verified: a TestFlight or App Store build upgrading a mainnet wallet, and an outgoing Lightning payment after the upgrade (I had no external regtest invoice to pay).

@piotr-iohk piotr-iohk closed this Oct 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants