Repository navigation
chore: bump version 2.5.1 - #924
piotr-iohk wants to merge 5 commits into
Conversation
|
2.5.1 release preparation is finalized for validation at Dispatched checks on this exact revision: Both E2E workflows successfully resolved iOS archive/TestFlight upload will be performed manually in Xcode (2.5.1 build 198). The shared migration wallet-setup reference remains |
|
@piotr-iohk conflicts |
|
talosmachina
left a comment
There was a problem hiding this comment.
No findings. Hotfix 2.5.1 off v2.5.0: MARKETING_VERSION 2.5.1 and CURRENT_PROJECT_VERSION 198 on all six app, widget and notification configs, LDK Node exact pin 0.7.0-rc.66 to 0.7.0-rc.66.1, dated changelog. Reviewed 0db7616, full tier (dependency manifest), reasoned from the code and CI; iOS does not build on this box.
What I checked, and 3 candidates I ruled out
Read: the project.pbxproj hunks, Package.resolved, CHANGELOG.md
CI on the head: unit-tests and integration-tests green; e2e-tests still running when this was posted. The ovi-reviewer check is not tied to this diff.
Ruled out
- A missed target: every config that carried 2.5.0/197 now carries 2.5.1/198; the remaining
1.0/1entries are the test targets, unchanged on master too. - Pin and lockfile disagree:
Package.resolvedrevision0692193is exactly what ldk-node tagv0.7.0-rc.66.1points at, and that release carries theLDKNodeFFI.xcframework.zipitsPackage.swiftdownloads. - The CI pin commit:
4889cabis reverted by61f482a, so it nets to nothing in the diff.
Merge confidence: 4/5, e2e had not finished on this head when reviewed; unit and integration are green.
ovitrif
left a comment
There was a problem hiding this comment.
Verdict: ♻️ Comment
Review: diff 3 files.
Comment only, so this PR cannot be merged by accident: it is to be closed after the 2.5.1 store release, never merged into master. The LDK update reaches master through #928.
Findings:
N/A
release-2.5.1differs fromv2.5.0only in build 198, version 2.5.1, LDK Node0.7.0-rc.66.1and the dated 2.5.1 changelog.Package.resolvedpins0.7.0-rc.66.1at 0692193, the tagged release commit, and itsLDKNodeFFI.xcframework.zipmatches thePackage.swiftchecksum.0.7.0-rc.66.1is the rc.66 source with onlylightning,lightning-liquidityandlightning-transaction-syncat 0.2.7.
Reviewed by claude-opus-5-5 via gh-pr-review-loop skill
jvsena42
left a comment
There was a problem hiding this comment.
No findings at 0db7616, reviewed against v2.5.0 (the tag this hotfix is cut from). The merge conflicts with master are expected, since this branch closes after the store release instead of merging. I'm posting this as a comment rather than an approval so it can't be merged by accident.
Checked and clean:
- Diff
v2.5.0..0db7616: three files.MARKETING_VERSION2.5.1 and build 198 on all six app, widget and notification configurations. ldk-node0.7.0-rc.66→0.7.0-rc.66.1in bothproject.pbxprojandPackage.resolved. The dated[2.5.1]changelog section and links.4889cabis reverted by61f482a, so it nets to nothing. - ldk-node
v0.7.0-rc.66...v0.7.0-rc.66.1: 3 commits. The onlyCargo.tomlchanges are the version andlightning,lightning-liquidityandlightning-transaction-sync0.2.0 → 0.2.7, plus a committedCargo.lockand rebuilt binaries. The tag resolves to0692193, the pinned revision. Androidv2.5.1pins the same0.7.0-rc.66.1. - CI at
0db7616: the dispatched unit, integration and e2e runs are green. E2E Migration was never run at this head (its only run, on51ad7d1, was skipped), so I ran the upgrade by hand, below.
Device gate: 0db7616 — 2.5.0 → 2.5.1 upgrade on the iPhone 17 simulator (iOS 26.5), regtest staging: 1 passed; perf: not relevant; Figma: n/a; Android: v2.5.1 already published with the same LDK Node.
- On
v2.5.0(build 197): new wallet, 300 000 sats received on-chain, then Transfer to Spending of 100 000. The channel became ready at 13:21:14 UTC. Savings 197 422, Spending 100 000. - This head (build 198) installed over it: savings, spending and activity unchanged. The node started at 13:21:51 and reconnected to the LSP with
channel_reestablish. - After the upgrade: received a 5 000-sat Lightning payment over the pre-upgrade channel, and Spending went to 105 000:
13:21:51.910 INFO Node started [LightningService.swift: start(onEvent:) line: 276] 13:21:52.571 INFO Connected to peer 028a8910…69fc@34.65.86.104:9400. - [LDK] [ldk_node:1298] 13:23:45.784 DEBUG Handling event PaymentClaimed { receiver_node_id: Some(…), payment_hash: 26e21c31… } - Log noise: the "Background sync of RGS gossip data failed" error also appears on
v2.5.0against staging, so it is not a regression. "Node is not setup" and "balances is nil" appear only during startup, before the node started.
Prepare Bitkit 2.5.1 (build 198) from
v2.5.0with LDK Node0.7.0-rc.66.1for upstream Lightning security fixes.Description
Design
N/A — no UI changes.
Preview
N/A
QA Notes
Journeys
Existing Lightning payment and wallet recovery journeys apply.
Manual Tests
Release runtime validation remains pending.
Automated Checks
Version metadata and changelog structure verified; diff whitespace checks passed. Branch-dispatched CI and regular E2E will be linked in a follow-up comment. E2E uses
release-2.5.1in the test repo, initially identical to tag2.5.0. Migration is deferred.