Skip to content

chore: usdt review journey and changelog match android - #1082

Merged
ovitrif merged 2 commits into
masterfrom
docs/usdt-journey-fixture-and-changelog
Oct 22, 2026
Merged

ovitrif merged 2 commits into
masterfrom
docs/usdt-journey-fixture-and-changelog

Conversation

@ovitrif

@ovitrif ovitrif commented Oct 21, 2026 •

Copy link
Copy Markdown
Collaborator

Twin: synonymdev/bitkit-android#1637

This PR keeps two texts from #1062 in step with the Android twin, after review on synonymdev/bitkit-android#1637 (review): the crowded-details step in paykit-quoted-usdt.xml now names the local USDT fixture it needs for quotes, and the changelog fragment says what users see change.

Description

  • paykit-quoted-usdt.xml: the step for a USDT request with a long invoice note now starts with "Using the local USDT fixture for quotes", the same words as on Android. Without that fixture a runner only reaches a quote failure; the Capabilities table in journeys/README.md already lists the fixture.
  • paykit-quoted-usdt.xml: the USDT-only contact's Amount step now expects the balance, chips and keypad at the bottom above Continue, as on direct USDT Send. fix: usdt amount keypad sits above continue #1061 moved the free space between the amount and the balance, so the old wording ("the balance stays close below the amount") no longer held (review).
  • changelog.d/next/1060.fixed.md: reworded from "The USDT payment details now fit the longest set of details" to name the change: the fee note no longer crowds Hide Details, and long details scroll above a pinned Swipe To Pay.

Design

N/A — no UI changes.

Preview

N/A

QA Notes

Setup

N/A — journey and changelog text only.

Journeys

  • J1: updated paykit-quoted-usdt.xml — the crowded USDT request step names the local USDT fixture it needs for quotes, and the USDT-only Amount step matches the Bitcoin amount layout

Manual Tests

N/A

Automated Checks

N/A

Evidence

xmllint passes on the journey, and both changed steps match the Android twin word for word.

Gaps

None.

@ovitrif ovitrif self-assigned this Oct 21, 2026
@ovitrif
ovitrif requested a review from pwltr October 21, 2026 14:25
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-21T14:26:45.684257Z f268440 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@greptile-apps

greptile-apps Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] This text-only PR appears safe to merge.

Summary

This PR clarifies two texts without changing app behavior.

  • The changelog explains the expanded USDT review layout more clearly.
  • The USDT review journey names the quote fixture it needs.

Reviews (1) · Last reviewed commit: "chore: usdt review journey and changelog..." · Reviewed by Greptile

@talosmachina talosmachina left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No findings. Aligns the crowded-details step of paykit-quoted-usdt.xml and the 1060.fixed.md changelog fragment with the Android twin. Reviewed f268440, light tier.

What I checked, and 1 candidate I ruled out

Read in full: journeys/paykit-quoted-usdt.xml, changelog.d/next/1060.fixed.md, the USDT rows of journeys/README.md (Capabilities table and Paykit sections)
CI: pending at review time (Run Tests, Integration Tests, SwiftFormat, validate); Greptile passed

Ruled out

  • Step names a fixture the README does not define: the Capabilities table lists the local USDT gateway/RPC/bundler fixture for controlled quotes, so a runner can resolve the new precondition.

Merge confidence: 4/5, text-only change but CI was still running when I reviewed.

@ovitrif ovitrif added this to the 3.1.0 milestone Oct 21, 2026
@ovitrif

ovitrif commented Oct 21, 2026

Copy link
Copy Markdown
Collaborator Author

Milestone 3.1.0: it aligns the iOS journey and changelog text with synonymdev/bitkit-android#1637 (3.1.0); it closes no issue, so the PR carries the milestone.

Paykit USDT Amount journey step matches the Bitcoin amount layout.
@ovitrif
ovitrif merged commit 2f3d35f into master Oct 22, 2026
19 of 20 checks passed
@ovitrif
ovitrif deleted the docs/usdt-journey-fixture-and-changelog branch October 22, 2026 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants