Skip to content

feat: use dropdown chevron on funding source - #1041

Open
jvsena42 wants to merge 6 commits into
masterfrom
feat/funding-source-dropdown-button
Open

jvsena42 wants to merge 6 commits into
masterfrom
feat/funding-source-dropdown-button

Conversation

@jvsena42

@jvsena42 jvsena42 commented Oct 20, 2026 •

Copy link
Copy Markdown
Member

This PR replaces the switch icon on the Send Amount funding source button with a dropdown chevron, matching the new design.

Description

  • Restyles the funding source button on Send Amount as an outlined button with a trailing down chevron when more than one wallet can pay, so it reads as a dropdown instead of a toggle
  • Keeps the funding source button outlined with no icon when only one wallet can pay
  • Adds a down chevron icon taken from the Figma arrow
  • Adds the funding-source-dropdown.xml journey to cover the button and its list

Out of Scope

  • Send Amount: the dropdown list itself, which already matches the design
  • Send Amount: label letter spacing stays at the existing caption style instead of the design's 1 px

Design

Preview

Spending selected Dropdown open Savings selected Single source
Spending selected Dropdown open Savings selected Single source

QA Notes

Journeys

  • new funding-source-dropdown.xml — the switchable funding source button is outlined with a down chevron and opens the wallet list

Manual Tests

N/A

Automated Checks

N/A

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ovitrif ovitrif added this to the 3.1.0 milestone Oct 20, 2026
@ovitrif

ovitrif commented Oct 20, 2026

Copy link
Copy Markdown
Collaborator

Triage: milestone 3.1.0, with its twin synonymdev/bitkit-android#1612. It closes no issue, so this PR carries the milestone itself. Not a release blocker.

@greptile-apps

greptile-apps Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 4/5

[Low impact] The change reaches the funding-source button on the iOS Send Amount screen.

The PR appears safe to merge, with a non-blocking wording correction in the new journey.

Findings

  1. P2 Journey describes the wrong behavior ▶

Summary

The PR gives the Send Amount wallet picker an outline and replaces its leading switch arrows with a trailing dropdown chevron.

  • The Send Amount wallet picker shows a down chevron when several wallets can pay.

Reviews (1) · Last reviewed commit: "feat: use dropdown chevron on funding so..." · Reviewed by Greptile

Comment thread journeys/send/funding-source-dropdown.xml Outdated

@talosmachina talosmachina left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No findings. Replaces the leading arrow-up-down icon on the Send Amount funding source button with a trailing chevron-down asset when more than one source can pay, keeps the button on the outlined .secondary variant in every case, and adds the funding-source-dropdown journey. Reviewed 9ddfd29, full tier, reasoned from the code and CI (iOS does not build on this box).

What I checked, and 3 candidates I ruled out

Read in full: SendAmountView.swift (the funding source row and assetButtonTestIdentifier), NumberPadActionButton.swift at the PR head
CI: SwiftFormat red, with every annotation in ElectrumSettingsScreen.swift and RgsSettingsScreen.swift (not in this diff), and the same check fails on master at f898732; tests and integration tests pending at review time; validate green

Ruled out

  • Chevron renders white instead of the source color: the imageset sets template-rendering-intent: template, so .foregroundColor(color) tints it, the same as the existing chevron imageset.
  • SVG asset unsupported: the catalog already ships 15 other SVG icons with preserves-vector-representation.
  • Test id changes for the journey: AssetButton-switch still comes from assetButtonTestIdentifier when canSwitchFundingSource is true, so the existing popover anchor and ids are unchanged.

Merge confidence: 4/5, SwiftFormat is red on files outside this diff (also red on master) and the test jobs had not reported yet.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@jvsena42 jvsena42 self-assigned this Oct 20, 2026
@jvsena42
jvsena42 requested review from a team, ben-kaufman and pwltr and removed request for a team October 20, 2026 14:55
@jvsena42
jvsena42 enabled auto-merge October 20, 2026 16:18
@ovitrif

ovitrif commented Oct 20, 2026

Copy link
Copy Markdown
Collaborator

@jvsena42 the red SwiftFormat check here comes from master's own files, which #1040 fixed (merged). Syncing this branch with master turns it green; if it still fails after that, run SwiftFormat 0.64.0 on this PR's changed files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants