Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Triage: milestone 3.1.0, with its twin synonymdev/bitkit-android#1612. It closes no issue, so this PR carries the milestone itself. Not a release blocker. |
[Low impact] The change reaches the funding-source button on the iOS Send Amount screen. The PR appears safe to merge, with a non-blocking wording correction in the new journey. Findings
SummaryThe PR gives the Send Amount wallet picker an outline and replaces its leading switch arrows with a trailing dropdown chevron.
Reviews (1) · Last reviewed commit: "feat: use dropdown chevron on funding so..." · Reviewed by Greptile |
talosmachina
left a comment
There was a problem hiding this comment.
No findings. Replaces the leading arrow-up-down icon on the Send Amount funding source button with a trailing chevron-down asset when more than one source can pay, keeps the button on the outlined .secondary variant in every case, and adds the funding-source-dropdown journey. Reviewed 9ddfd29, full tier, reasoned from the code and CI (iOS does not build on this box).
What I checked, and 3 candidates I ruled out
Read in full: SendAmountView.swift (the funding source row and assetButtonTestIdentifier), NumberPadActionButton.swift at the PR head
CI: SwiftFormat red, with every annotation in ElectrumSettingsScreen.swift and RgsSettingsScreen.swift (not in this diff), and the same check fails on master at f898732; tests and integration tests pending at review time; validate green
Ruled out
- Chevron renders white instead of the source color: the imageset sets
template-rendering-intent: template, so.foregroundColor(color)tints it, the same as the existingchevronimageset. - SVG asset unsupported: the catalog already ships 15 other SVG icons with
preserves-vector-representation. - Test id changes for the journey:
AssetButton-switchstill comes fromassetButtonTestIdentifierwhencanSwitchFundingSourceis true, so the existing popover anchor and ids are unchanged.
Merge confidence: 4/5, SwiftFormat is red on files outside this diff (also red on master) and the test jobs had not reported yet.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This PR replaces the switch icon on the Send Amount funding source button with a dropdown chevron, matching the new design.
Description
funding-source-dropdown.xmljourney to cover the button and its listOut of Scope
Design
Preview
QA Notes
Journeys
funding-source-dropdown.xml— the switchable funding source button is outlined with a down chevron and opens the wallet listManual Tests
N/A
Automated Checks
N/A
🤖 Generated with Claude Code