Skip to content

feat: use dropdown chevron on funding source - #1612

Merged
ovitrif merged 3 commits into
masterfrom
feat/funding-source-dropdown-button
Oct 21, 2026
Merged

ovitrif merged 3 commits into
masterfrom
feat/funding-source-dropdown-button

Conversation

@jvsena42

@jvsena42 jvsena42 commented Oct 20, 2026 •

Copy link
Copy Markdown
Member

This PR replaces the switch icon on the Send Amount funding source button with a dropdown chevron, matching the new design.

Description

  • Restyles the funding source button on Send Amount as an outlined button with a trailing down chevron when more than one wallet can pay, so it reads as a dropdown instead of a toggle
  • Outlines the funding source button with no icon when only one wallet can pay, matching the iOS single-source style
  • Adds a down chevron icon taken from the Figma arrow
  • Adds the funding-source-dropdown.xml journey to cover the button and its list

Out of Scope

  • Send Amount: the dropdown list itself, which already matches the design
  • Send Amount: label letter spacing stays at the existing caption style instead of the design's 1 px

Design

Preview

Spending selected Dropdown open Savings selected Single source Single source, dropdown
Spending selected Dropdown open Savings selected Single source Single source dropdown with Spending disabled

QA Notes

Journeys

  • new funding-source-dropdown.xml — the switchable funding source button is outlined with a down chevron and opens the wallet list

Manual Tests

N/A

Automated Checks

N/A

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ovitrif ovitrif added this to the 3.1.0 milestone Oct 20, 2026
@ovitrif

ovitrif commented Oct 20, 2026

Copy link
Copy Markdown
Collaborator

Triage: milestone 3.1.0. A design update to the Send Amount funding source button; it closes no issue, so this PR carries the milestone itself. Not a release blocker.

@ovitrif

ovitrif commented Oct 20, 2026

Copy link
Copy Markdown
Collaborator

Twin: synonymdev/bitkit-ios#1041.

@greptile-apps

greptile-apps Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 4/5

[Low impact] The change is limited to one Android control on the Send Amount screen.

The PR appears safe to merge, with a non-blocking correction needed in the journey description.

Findings

  1. P2 Single-source expectation is wrong ▶

Summary

Updates the Send Amount funding source button to use an outline and a trailing down chevron when multiple sources are available.

  • Send Amount shows a dropdown arrow when more than one wallet can pay.

Reviews (1) · Last reviewed commit: "feat: use dropdown chevron on funding so..." · Reviewed by Greptile

Comment thread journeys/send/funding-source-dropdown.xml Outdated

@talosmachina talosmachina left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No findings. Swaps the funding source button on Send Amount from a filled button with the ic_transfer icon to an outlined button with a trailing ic_chevron_down when more than one source can pay, and adds the funding-source-dropdown journey. Reviewed 1f37ed5, full tier, reasoned from the code and CI (Bitkit Android branches are not built here).

What I checked, and 3 candidates I ruled out

Read in full: SendAmountScreen.kt (PaymentMethodButton), NumberPadActionButton.kt at the PR head
CI: build and lint still pending at review time; detect-changes and e2e-branch/determine green

Ruled out

  • Trailing icon lost in the disabled state: the enabled = false branch of NumberPadActionButton renders trailingIcon too, and canSwitchFundingSource implies non-empty fundingOptions, so that branch is not reached with a chevron anyway.
  • Outlined border hides the loading state: the loading indicator is drawn before the label regardless of outlined, and the border uses the same color as the label.
  • Chevron drawable scaled wrong: a 32x32 viewport drawn at Modifier.size(16.dp) keeps its proportions; the #ffffff fill is replaced by the tint.

Merge confidence: 4/5, build and lint had not reported yet and no test covers this restyle beyond the new manual journey.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Regtest APK

Built from c0b8dd7 (run).

Download bitkit-dev-debug universal APK (expires in 30 days).

@jvsena42 jvsena42 self-assigned this Oct 20, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@jvsena42
jvsena42 requested review from a team, ben-kaufman and coreyphillips and removed request for a team October 20, 2026 14:55
@jvsena42
jvsena42 enabled auto-merge October 20, 2026 16:18

@coreyphillips coreyphillips left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two independent reviews, nothing blocking a merge.

@ovitrif
ovitrif merged commit 4bb4177 into master Oct 21, 2026
21 checks passed
@ovitrif

ovitrif commented Oct 21, 2026

Copy link
Copy Markdown
Collaborator

Merged, as it was approved and green.

@ovitrif
ovitrif deleted the feat/funding-source-dropdown-button branch October 21, 2026 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants