Repository navigation
feat: use dropdown chevron on funding source - #1612
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Triage: milestone 3.1.0. A design update to the Send Amount funding source button; it closes no issue, so this PR carries the milestone itself. Not a release blocker. |
|
Twin: synonymdev/bitkit-ios#1041. |
[Low impact] The change is limited to one Android control on the Send Amount screen. The PR appears safe to merge, with a non-blocking correction needed in the journey description. Findings
SummaryUpdates the Send Amount funding source button to use an outline and a trailing down chevron when multiple sources are available.
Reviews (1) · Last reviewed commit: "feat: use dropdown chevron on funding so..." · Reviewed by Greptile |
talosmachina
left a comment
There was a problem hiding this comment.
No findings. Swaps the funding source button on Send Amount from a filled button with the ic_transfer icon to an outlined button with a trailing ic_chevron_down when more than one source can pay, and adds the funding-source-dropdown journey. Reviewed 1f37ed5, full tier, reasoned from the code and CI (Bitkit Android branches are not built here).
What I checked, and 3 candidates I ruled out
Read in full: SendAmountScreen.kt (PaymentMethodButton), NumberPadActionButton.kt at the PR head
CI: build and lint still pending at review time; detect-changes and e2e-branch/determine green
Ruled out
- Trailing icon lost in the disabled state: the
enabled = falsebranch ofNumberPadActionButtonrenderstrailingIcontoo, andcanSwitchFundingSourceimplies non-emptyfundingOptions, so that branch is not reached with a chevron anyway. - Outlined border hides the loading state: the loading indicator is drawn before the label regardless of
outlined, and the border uses the samecoloras the label. - Chevron drawable scaled wrong: a 32x32 viewport drawn at
Modifier.size(16.dp)keeps its proportions; the#fffffffill is replaced by thetint.
Merge confidence: 4/5, build and lint had not reported yet and no test covers this restyle beyond the new manual journey.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Regtest APKDownload bitkit-dev-debug universal APK (expires in 30 days). |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
coreyphillips
left a comment
There was a problem hiding this comment.
Two independent reviews, nothing blocking a merge.
|
Merged, as it was approved and green. |
This PR replaces the switch icon on the Send Amount funding source button with a dropdown chevron, matching the new design.
Description
funding-source-dropdown.xmljourney to cover the button and its listOut of Scope
Design
Preview
QA Notes
Journeys
funding-source-dropdown.xml— the switchable funding source button is outlined with a down chevron and opens the wallet listManual Tests
N/A
Automated Checks
N/A
🤖 Generated with Claude Code