Repository navigation
Give IntegrationPlugin's per-type methods a kind - #66
Merged
Merged
Conversation
- PointKind is the one kind of point: InputKind, typed by its points, and OutputKind are its subsets, and every kind is in PointKind. InputKind's own objects are gone. - uninstall(kind) replaces the seven uninstall methods, generatePattern (kind) the three pattern methods, and checkOperate(kind, index) and checkNotOperate(kind) the four operate checks. - DefaultIntegrationPlugin asks the same as before; uninstalling frozen counters and analog inputs asks for "every ... point" like the rest. The procedures' steps are unchanged. A plugin implements the four methods in place of the fourteen; its uninstall handles frozen counters and analog inputs too, which had a default that threw. Part of #59.
This was referenced Oct 14, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Item 6 of #59.
Changes
PointKindis now the one kind of point.InputKind[P], typed by its points, and a newOutputKindare its subsets, and every kind is an object inPointKind.InputKind's own objects are gone.uninstall(reporter, kind)replaces the sevenuninstall*methods. It's abstract. Two of the methods it replaces, for frozen counters and analog inputs, had defaults that threw, so a plugin now handles every kind or throws itself.generatePattern(reporter, kind)replaces the threegenerate*Patternmethods.checkOperate(reporter, kind, index)andcheckNotOperate(reporter, kind)replace the fourcheck*Operatemethods.DefaultIntegrationPluginasks the same questions as before, except that uninstalling frozen counters and analog inputs now asks for "every ... point" like the other kinds. The procedures' steps are unchanged.Downstream
stepfunc/dnp3's conformance plugin needs the matching change: it implements the four new methods, renames
InputKind.XtoPointKind.X, and dropssupports.noClassAssignmentfrom its configuration files. That change is ready on dnp3'sdnp3c-3.1r1branch, and I'll push it after this merges.Checks
mvn testpasses.