Skip to content

Give the uninstall and operate-check steps a kind - #80

Merged
jadamcrain merged 1 commit into
mainfrom
plugin-steps-by-kind
Oct 15, 2026
Merged

jadamcrain merged 1 commit into
mainfrom
plugin-steps-by-kind

Conversation

@jadamcrain

Copy link
Copy Markdown
Member

Since #66, IntegrationPlugin's uninstall and operate-check methods take a PointKind or OutputKind. PluginSteps still had one uninstall step per point kind and one set of operate checks per output kind. OperationType, PointRanges, StaticInputs and the configurable input procedures each mapped a kind back to the matching wrapper.

This change:

  • replaces the seven uninstall* steps with PluginSteps.uninstall(kind), and the six operate checks with checkOperate(kind, index | indices) and checkNotOperate(kind). Each kind keeps the exact step text it had.
  • gives OperationType its output kind in place of four per-output defs. PointRanges, StaticInputs.Configurable and ConfigurableInputProcedure take a PointKind in place of a prebuilt step.
  • adds PluginSteps.removal(kind), the uninstall step paired with the restore that reinstalls the points, which four procedures built by hand.

The generate and event steps keep their own wrappers, since their text says something specific to each procedure. Neither IntegrationPlugin nor the configuration changes.

Every procedure's -describe output, for both 2.7 and 3.1r1, is byte-identical before and after.

Sweep: grepped for every uninstall*, check*Operate and reinstallPoints use, and for each Undoable(…, reinstallPoints); none are left outside PluginSteps.

PluginSteps had one uninstall step per point kind and one operate check
per output kind, and OperationType, PointRanges, StaticInputs and the
configurable input procedures mapped each kind back to its wrapper. The
steps now take the kind, keeping each step's text, and PluginSteps.removal
gives the uninstall with its reinstalling restore that four procedures
built by hand.
@jadamcrain
jadamcrain added this pull request to the merge queue Oct 15, 2026
Merged via the queue into main with commit df6bd7b Oct 15, 2026
5 checks passed
@jadamcrain
jadamcrain deleted the plugin-steps-by-kind branch October 15, 2026 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant