Repository navigation
Give the uninstall and operate-check steps a kind - #80
Merged
Merged
Conversation
PluginSteps had one uninstall step per point kind and one operate check per output kind, and OperationType, PointRanges, StaticInputs and the configurable input procedures mapped each kind back to its wrapper. The steps now take the kind, keeping each step's text, and PluginSteps.removal gives the uninstall with its reinstalling restore that four procedures built by hand.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #66,
IntegrationPlugin's uninstall and operate-check methods take aPointKindorOutputKind.PluginStepsstill had one uninstall step per point kind and one set of operate checks per output kind.OperationType,PointRanges,StaticInputsand the configurable input procedures each mapped a kind back to the matching wrapper.This change:
uninstall*steps withPluginSteps.uninstall(kind), and the six operate checks withcheckOperate(kind, index | indices)andcheckNotOperate(kind). Each kind keeps the exact step text it had.OperationTypeits output kind in place of four per-output defs.PointRanges,StaticInputs.ConfigurableandConfigurableInputProceduretake aPointKindin place of a prebuilt step.PluginSteps.removal(kind), the uninstall step paired with the restore that reinstalls the points, which four procedures built by hand.The generate and event steps keep their own wrappers, since their text says something specific to each procedure. Neither
IntegrationPluginnor the configuration changes.Every procedure's
-describeoutput, for both 2.7 and 3.1r1, is byte-identical before and after.Sweep: grepped for every
uninstall*,check*OperateandreinstallPointsuse, and for eachUndoable(…, reinstallPoints); none are left outsidePluginSteps.