Repository navigation
Validate only the procedures that apply at the run's subset level - #64
Merged
Merged
Conversation
Revision.validate collected the configuration problems of every selected procedure that's implemented and enabled, including those that don't apply at the configured subset level, which a run skips. A 3.1r1 run at level 2 could be refused for what 8.26.3, a level 3 test, needs. It now checks the procedures the run will run: implemented, applicable at the level, and enabled. Part of #59.
This was referenced Oct 14, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while doing item 4 of #59.
Revision.validatecollected configuration problems from every selected procedure that's implemented and enabled. That included procedures that don't apply at the configured subset level, even though the runner skips those without running them. So a 3.1r1 run at level 2 could be refused because the configuration lacked what 8.26.3, a level 3 test, needs.validatenow checks only the procedures the run will actually run: those that are implemented, apply at the level, and are enabled. These are the same conditionsTestRunner.skipReasonuses. A new test checks both cases: at level 1 the level 2 procedure's problem is ignored, and at level 2 it's reported.