Skip to content

One decision for whether a procedure runs, so -disabled lists each once - #75

Merged
jadamcrain merged 1 commit into
mainfrom
one-skip-decision
Oct 15, 2026
Merged

jadamcrain merged 1 commit into
mainfrom
one-skip-decision

Conversation

@jadamcrain

Copy link
Copy Markdown
Member

Changes

  • One decision. Revision.skip(procedure, options, level) says why a procedure won't run on a device configured for a subset level: it isn't implemented, it doesn't apply at that level, or an option disables it. The runner's skip reasons, Revision.validate and -disabled all use it, along with -describe's "not applicable" message. Before, each decided on its own, and they had already drifted once (Validate only the procedures that apply at the run's subset level #64).
  • -disabled lists each procedure once. A procedure that doesn't apply at the configured level and is also disabled by an option was listed twice: as not applicable and again with its options. For example, 3.1r1's level 1 read tests (8.13.2a, 8.14.2a, …) appeared twice at levels 2 and 3, and 8.26.3 twice at levels 1 and 2 with supports.assignNoClass = false. It is now listed once, as not applicable. The output is otherwise unchanged: the same groups, order and lines.
  • The runner's skip messages and -describe's output are unchanged.

Checks

  • -disabled output. Compared for both revisions at every subset level, with the defaults, a device profile, and every boolean option on and off, before and after. The only differences are the duplicate entries going away.
  • -describe output. Unchanged.
  • Tests. New tests check that -disabled lists each procedure once at every level and setting, and that the runner, the configuration check and -disabled agree on which procedures run. mvn test passes.

The runner, the configuration check and -disabled each decided on their own
whether a procedure runs at the configured subset level. -disabled listed a
procedure that doesn't apply at the level and is also disabled by an option
twice, e.g. 3.1r1's level 1 read tests at levels 2 and 3. Revision.skip now
gives the reason, and all three use it.
@jadamcrain
jadamcrain added this pull request to the merge queue Oct 15, 2026
Merged via the queue into main with commit 467b133 Oct 15, 2026
9 of 10 checks passed
@jadamcrain
jadamcrain deleted the one-skip-decision branch October 15, 2026 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant