Repository navigation
One decision for whether a procedure runs, so -disabled lists each once - #75
Merged
Merged
Conversation
The runner, the configuration check and -disabled each decided on their own whether a procedure runs at the configured subset level. -disabled listed a procedure that doesn't apply at the level and is also disabled by an option twice, e.g. 3.1r1's level 1 read tests at levels 2 and 3. Revision.skip now gives the reason, and all three use it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Revision.skip(procedure, options, level)says why a procedure won't run on a device configured for a subset level: it isn't implemented, it doesn't apply at that level, or an option disables it. The runner's skip reasons,Revision.validateand-disabledall use it, along with-describe's "not applicable" message. Before, each decided on its own, and they had already drifted once (Validate only the procedures that apply at the run's subset level #64).-disabledlists each procedure once. A procedure that doesn't apply at the configured level and is also disabled by an option was listed twice: as not applicable and again with its options. For example, 3.1r1's level 1 read tests (8.13.2a, 8.14.2a, …) appeared twice at levels 2 and 3, and 8.26.3 twice at levels 1 and 2 withsupports.assignNoClass = false. It is now listed once, as not applicable. The output is otherwise unchanged: the same groups, order and lines.-describe's output are unchanged.Checks
-disabledoutput. Compared for both revisions at every subset level, with the defaults, a device profile, and every boolean option on and off, before and after. The only differences are the duplicate entries going away.-describeoutput. Unchanged.-disabledlists each procedure once at every level and setting, and that the runner, the configuration check and-disabledagree on which procedures run.mvn testpasses.