Repository navigation
Implement "roxie update" command for self-updating #323
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,66 @@ | ||
| package main | ||
|
|
||
| import ( | ||
| "fmt" | ||
| "os" | ||
|
|
||
| "github.com/creativeprojects/go-selfupdate" | ||
| "github.com/spf13/cobra" | ||
| log "github.com/stackrox/roxie/internal/logger" | ||
| ) | ||
|
|
||
| const ( | ||
| updateRepoOwner = "stackrox" | ||
| updateRepoName = "roxie" | ||
| ) | ||
|
|
||
| func newUpdateCmd() *cobra.Command { | ||
| return &cobra.Command{ | ||
| Use: "update", | ||
| Short: "Update roxie to the latest version", | ||
| Long: `Download and install the latest roxie release from GitHub, replacing the current binary in-place.`, | ||
| RunE: runUpdate, | ||
| } | ||
| } | ||
|
|
||
| func runUpdate(cmd *cobra.Command, _ []string) error { | ||
| if version == "dev" { | ||
| return fmt.Errorf("cannot self-update a development build (version %q); install a released binary first", version) | ||
| } | ||
|
|
||
| updater, err := selfupdate.NewUpdater(selfupdate.Config{ | ||
| Validator: &selfupdate.ChecksumValidator{UniqueFilename: "checksums.txt"}, | ||
| }) | ||
| if err != nil { | ||
| return fmt.Errorf("initializing updater: %w", err) | ||
| } | ||
|
|
||
| log.Infof("Checking for updates (current version: %s)...", version) | ||
|
|
||
| latest, found, err := updater.DetectLatest(cmd.Context(), selfupdate.ParseSlug(updateRepoOwner+"/"+updateRepoName)) | ||
| if err != nil { | ||
| return fmt.Errorf("detecting latest version: %w", err) | ||
| } | ||
| if !found { | ||
| return fmt.Errorf("no releases found for %s/%s", updateRepoOwner, updateRepoName) | ||
| } | ||
|
|
||
| if latest.LessOrEqual(version) { | ||
| log.Infof("Already up to date (latest: %s).", latest.Version()) | ||
| return nil | ||
| } | ||
|
|
||
| log.Infof("Updating to %s...", latest.Version()) | ||
|
|
||
| exe, err := os.Executable() | ||
| if err != nil { | ||
| return fmt.Errorf("locating current executable: %w", err) | ||
| } | ||
|
|
||
| if err := updater.UpdateTo(cmd.Context(), latest, exe); err != nil { | ||
| return fmt.Errorf("updating binary: %w", err) | ||
| } | ||
|
Comment on lines
+55
to
+62
Contributor
There was a problem hiding this comment. Resolve symlinks before you replace the executable.
Resolve the path with 🐛 Proposed fix
 |
||
|
|
||
| log.Infof("Updated roxie: %s → %s", version, latest.Version()) | ||
| return nil | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script executed:
Repository: stackrox/roxie
Length of output: 152
Script executed:
Repository: stackrox/roxie
Length of output: 1019
Script executed:
Repository: stackrox/roxie
Length of output: 7950
Reject non-semver build versions before calling
LessOrEqual.Release.LessOrEqualcallssemver.MustParse(other). A non-"dev"version that is not valid semver can therefore panic at the comparison instead of returning a clear error.Makefilecan pass rawgit describe --tags --always --dirtyoutput toversion.Suggested fix