Repository navigation
Use one Core Load calculation for app, web and HA - #1733
Merged
Merged
Conversation
frahlg
marked this pull request as ready for review
October 18, 2026 16:56
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The phone could calculate house Load from smoothed readings while LAN used qualified source power. The native UI could then subtract EV draw again or turn missing Load into 0. HA and support reports also had their own live formulas.
Use one Core
LiveMeasurementNowpath and one source-options callback for LAN, phone sessions, Cloud, HA and live diagnostics. It uses measured site-side power, driver cadence and the existing balance checks. Remove the extra residuals, clamps and unused household filter.Core sends a known 0 as 0. Invalid or missing Load becomes JSON null, an absent existing FID6, MQTT
None, or unavailable text in the support report. The session's existing full-snapshot path clears a previously known value. The web view renders Core's Load without a second decision based on aggregate history quality. Historical energy intervals remain a separate quantity from current power.Paired native client fix: srcfl/ftw-app#94. It preserves Core Load and its absence in iOS, Watch and the shared view model. Older app builds still need that client update. The continuous graph draft in app #93 is separate.
Validation:
LiveView, including removal of an earlier value through a full snapshot.Nonefor unknown: https://www.home-assistant.io/integrations/sensor.mqtt/#state_topic.make verifystopped in the existing OCPP listener-start test (control_test.go:369). Its result is preserved; no deadline or assertion changed. The controlledmake verifyrerun, all web tests and uncached full Go race pass on exact head4daab0799ead10d9abdbf4ab66bdbe7d476ca6bb. The race run completed 16:54:36 UTC with no failures or race warnings. Other local builds and cache cleanup stayed paused. The original startup-test cause remains unproven.Fredrik asked for one calculation in Core and authorized this chat to publish the common beta and install it on his box. His earlier stable and migration holds remain separate from this beta review. No beta from this PR has been published or installed yet.