Skip to content

Keep Core load unchanged in the iOS charger display - #94

Merged
frahlg merged 1 commit into
mainfrom
codex/ios-core-load-preservation-20261018
Oct 18, 2026
Merged

frahlg merged 1 commit into
mainfrom
codex/ios-core-load-preservation-20261018

Conversation

@frahlg

@frahlg frahlg commented Oct 18, 2026 •

Copy link
Copy Markdown
Member

The iOS charger display could subtract charger watts from Core’s qualified house load, or create a false 0 W when Core omitted load. That also reached Watch through NowFlow. The app now leaves Core load unchanged while adding an EV display reading. An absent or null load stays unknown, a known zero stays zero, and the home remains visible with no reading.

Paired Core PR: srcfl/ftw#1733 (reviewed source head 4daab0799ead10d9abdbf4ab66bdbe7d476ca6bb). Core uses one qualified live-load calculation for local status, app snapshots and FTW Cloud. It changes no wire field or registry name. withLoadpointEV keeps its signature; the legacy Readings.loadKw is now optional so that API can represent missing load. Current app/widget/Watch targets compile with it.

Validation:

  • Four new regressions fail on unchanged main with 17 assertion issues, then pass after the fix. They cover absent/zero/fractional load with charger fallback, missing/null HTTP load, Now, and Watch.
  • Full Swift checks: 266 shared tests and 551 kit tests pass.
  • Native iOS Simulator app, widget and Watch build passes. Remote Apple CI run 39145749162 also passes its package tests, native targets and normal demo photographs. The CI photographs show the ordinary demo. A separate local native UI test also passes: after a known 1.6 kW reading, a full snapshot omits FID6 and both Now and the detail view show unknown; another run shows known Load=0 as 0 W. Its five screenshots and result bundle are saved for review. Only the demo/test fixture changed for this render; that patch is saved outside the PR and the worktree is restored to the submitted head.
  • Android shared JVM checks pass on JDK 21: 44 tests, no failures or errors, one intentional skip.

This PR contains no timeline redesign; that remains draft #93. It does not publish or install an iOS beta, and Hannes’s exact installed app build remains unknown. The fix has not been verified on a physical iPhone or Watch.

Signed-off-by: Fredrik Ahlgren <fredrik@sourceful-labs.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-18T16:37:48.890332Z f3ee97a PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@frahlg frahlg reopened this Oct 18, 2026
@frahlg
frahlg merged commit a28966c into main Oct 18, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant