Repository navigation
Keep Core load unchanged in the iOS charger display - #94
Merged
Merged
Conversation
Signed-off-by: Fredrik Ahlgren <fredrik@sourceful-labs.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Oct 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The iOS charger display could subtract charger watts from Core’s qualified house load, or create a false 0 W when Core omitted load. That also reached Watch through NowFlow. The app now leaves Core load unchanged while adding an EV display reading. An absent or null load stays unknown, a known zero stays zero, and the home remains visible with no reading.
Paired Core PR: srcfl/ftw#1733 (reviewed source head
4daab0799ead10d9abdbf4ab66bdbe7d476ca6bb). Core uses one qualified live-load calculation for local status, app snapshots and FTW Cloud. It changes no wire field or registry name.withLoadpointEVkeeps its signature; the legacyReadings.loadKwis now optional so that API can represent missing load. Current app/widget/Watch targets compile with it.Validation:
This PR contains no timeline redesign; that remains draft #93. It does not publish or install an iOS beta, and Hannes’s exact installed app build remains unknown. The fix has not been verified on a physical iPhone or Watch.