Repository navigation
docs(agents): a consent link or QR code goes straight to review in the app - #1690
Merged
Merged
Conversation
…e app The app no longer asks the owner to type the consent page's code when they open its link or scan its QR code. The code is for an owner who has neither. A link someone else sent reaches the review too, and stops at Face ID and the offer's 10 minutes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Oct 17, 2026
The link and the QR code carry the offer; the code only finds it at FTW Cloud. The app shows the code only for a link, reads the QR code with its own scanner too, and a sent link stops at the pinned-key check, the unverified client's own step, Face ID and the offer's 10 minutes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
docs/agents.md, The grant offer, says that on the universal-link path the owner types the consent page's code, and on the QR path compares it. On 17 October 2026 Fredrik decided otherwise: a link or the QR code goes straight to approval, and the code is only for an owner who has neither.Change
Two places. The intro now says the link and the QR code carry the offer, and the code only finds it at FTW Cloud's code lookup. The app paragraph: a link, tapped or opened by the camera or the app's own scanner from the QR code, goes straight to review, which then also shows the code to compare. Nothing asks the owner to, so a link someone else sent reaches the review too; what stops it there is the pinned-key check, the unverified client's "I started this" step, Face ID and the offer's 10 minutes. The owner types the code only without the QR code or the link.
The box's own Access page (
web/settings/tabs/access.js) is unchanged: it has no link and keeps the typed code. Documentation only, so no changeset.Paired
🤖 Generated with Claude Code