Repository navigation
fix(oauth): the consent page says to scan the QR code or open the link - #30
Merged
Merged
Conversation
The FTW app now goes straight to review from the link or the QR code, so the page leads with those. The code is for an owner who can do neither, in the FTW app or on the box's own page under Settings, then Access. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Oct 17, 2026
"Open the link" pointed at a button labelled Open the FTW app, which a desktop browser cannot open. The page now says to scan with the phone's camera or tap the button on the phone, and names where to type the code: Settings → Assistants and support → Add an assistant in the app, Settings → Access on the box's own page. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The FTW app now goes straight from the consent page's link or QR code to the review screen (srcfl/ftw-app#84). Typing the code is only for an owner who has neither. The page still read as if the code were part of every path.
Change
internal/oauth/page.go, building on #25:TestTheConsentPagechecks the new words. No other change: the offer, the code lookup and the link are as they were.Evidence
go vet ./internal/oauth/andgo test -race ./internal/oauth/pass. The page as the test rig serves it, in headless Chrome:Nothing deployed.
Paired
🤖 Generated with Claude Code