Repository navigation
Conversation
Signed-off-by: Fredrik Ahlgren <fredrik@sourceful-labs.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
frahlg
added
the
no-changeset
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The race CI job can fail
TestDriverControlAmbiguousCommandRestoresDefaultbefore it reaches the condition the test needs. Its 10 ms request deadline can expire before the driver starts; in that case no command ran and no safety default is due. The test then waits for a default that should not occur.The Lua probe now reports when it has changed the value and begun the command. The test waits for that signal, cancels the request, then checks the same error, restored default and cleared hold. Only the test changes; driver and API behavior stay the same.
Validation: the unchanged test on
masterfailed 6 of 100 runs undergo test -race. The fixed test passes 100 runs, and all driver-control/default tests pass with the race detector. No hardware was used.Found while checking #1683. This test fix is separate from the Cloud pairing change.