Repository navigation
feat(pairing): include the Cloud home in linked pairing QRs - #1683
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 71ffd0ef88
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Signed-off-by: Fredrik Ahlgren <fredrik@sourceful-labs.com>
Signed-off-by: Fredrik Ahlgren <fredrik@sourceful-labs.com>
Signed-off-by: Fredrik Ahlgren <fredrik@sourceful-labs.com>
frahlg
force-pushed
the
feat/cloud-qr-v3
branch
from
October 17, 2026 06:30
7569be0 to
e91caa4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new web client can reach its box through FTW Cloud only when the pairing QR names the Cloud home. Linked boxes now show QR v3. iPhone already reads it; the web client change requires it and asks old web installations to pair again. There is no Android release to migrate.
Paired web client: srcfl/ftw-webapp#95. Release this Core change before publishing that web client. An unlinked box still has no Cloud home to name. The protocol and registry are unchanged.
The local live-box fixture now uses
SetHome(link.Home)and the productionEnrollmentURL, so the cross-repo test proves the emitted QR rather than building v3 by hand.Validation:
make verifypassed. The web client's shipped pairing/connect stack paired through a real localftwclouddand this Core fixture with the relay unreachable, streamed, confirmed 30 commands and resumed five times. The readable copy was off. No physical hardware was used. No UI layout changed.Rollout check: the published
app.ftw.energybundle (/assets/index-YfKnxXTL.js, checked 17 October 2026) accepts bothv2and six-partv3QRs, includingE_QR_HOMEvalidation. That reader shipped in webapp #89 (ba20354). Current iPhone also reads v3. Older cached web clients need an update; the owner accepts re-pairing. The old reader warning indocs/protocol-cloud.mdis stale; #1682 already owns that file, so this PR does not rewrite it.CI: all checks passed on
7569be03. The first race job failed the existing driver cancellation test with no data race reported; a rerun passed. The unchanged test also failed 6 of 100 runs on master. Test-only fix: #1685 (100 fixed runs and all control/default tests pass under the race detector).