Skip to content

Reimplement the immediate synchronization hash command - #222

Open
Krarilotus wants to merge 1 commit into
sourcehold:mainfrom
Krarilotus:feat/sync-check-command
Open

Krarilotus wants to merge 1 commit into
sourcehold:mainfrom
Krarilotus:feat/sync-check-command

Conversation

@Krarilotus

@Krarilotus Krarilotus commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

TL;DR: Reconstruct the immediate command that exchanges player synchronization information.

This native function sends and receives lag, hash and match time for the existing synchronization checks.

Changes: Implement CommandCheckSync at 0x480B10 using the existing serializers/resolvers and the original ten-byte payload.

Review / testing: DLL build and native comparison cases passed; linked reccmp is 75.47%. The 203-byte native-bound comparison is a separate measurement. TheRedDaemon requested a status-file update, and the current PR still changes only the C++ file. Complete that review request before merging.

@Krarilotus

Copy link
Copy Markdown
Contributor Author

The build limitation is resolved: the normal full OpenSHC.dll target now passes using the existing MSVC2005 SP1 compiler and a Microsoft-signed Windows SDK manifest tool. All 2,560 original serializer/command cases still pass; the C++ commit is unchanged and no DLL was deployed. The description now reflects the successful full build.

@TheRedDaemon TheRedDaemon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is missing the status file update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants