Reimplement host synchronization checks and periodic messages - #223
Open
Krarilotus wants to merge 1 commit into
Open
Krarilotus wants to merge 1 commit into
Krarilotus wants to merge 1 commit into
Conversation
TheRedDaemon
requested changes
Sep 11, 2026
TheRedDaemon
left a comment
TheRedDaemon
left a comment
Contributor
There was a problem hiding this comment.
- Please add the status file updates.
- Also, we prefer explicit
this->accesses to member variables. - Should the files match, please remove the validation files.
- The readme is also not fitting, the partial explanation of the emulation validation would be naturally part of the agent skill. The rest is directly bound to this function and redundant.
| { | ||
| int referenceHash = 0; | ||
| int referenceTime = 0; | ||
| if (DAT_HashCountdown == 0) { |
Contributor
There was a problem hiding this comment.
You might be able to increase the readablility by switching this to an early return (if it does not break the byte matching).
| } | ||
| } | ||
|
|
||
| if (DAT_GameSynchronyState::instance.isHost && flag_0xbec == 0) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR: Reconstruct host synchronization checks and periodic sync messages.
OpenSHC needs readable C++ counterparts for the native host comparison, periodic sender and unit-buffer hash helper.
Changes: Implement the three functions through existing resolvers, retaining original timing, peer filtering, receiver identity and acknowledgements.
Review / testing: DLL build and 9,380 differential cases were reported passing. Linked reccmp scores are 98.02%, 92.59% and 60.00%. Outstanding maintainer requests: update status, use explicit
this->, remove matching validation files and the redundant validation README. The current diff still contains the validation directory and no status update. The native-bound byte match does not replace those requests.