🚚 Update remaining master references to main - #727
Merged
Conversation
The default branch is now `main`. GitHub retargeted the open pull requests, moved the Pages build branch, and redirects web and API requests for the old name, so what's left is the references we hard-code ourselves. The `master` entry in both workflows' `branches:` filters was only there to keep CI matching across the rename. It matches nothing now, so it goes. `gh_edit_branch` in `docs/_config.yml` is what just-the-docs builds the "Edit this page on GitHub" footer link from, on every docs page. Web redirects cover a stale value for now, but they're not worth relying on long term. The Coveralls badge takes `?branch=main` in both its image and its link. The `Test` badge moves to the per-workflow URL, which accepts a `branch` parameter, so it reads consistently with the Coveralls badge beside it. This one is a trade-off rather than a straight improvement: the old `/workflows/Test/badge.svg` form implicitly tracked whatever the default branch happened to be, so it would have survived this rename — and any future one — untouched, where the pinned form won't. Left alone deliberately: `coverallsapp/github-action@master` and the `ottypes/json1` links name branches in other repositories, and GitHub explicitly doesn't redirect `uses:` refs. Coveralls still has `master` as the project's default branch in its own settings, which we can't change from here, so the coverage badge will read as unknown until a build reports on `main`. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default branch is now
main. GitHub retargeted the open pull requests, moved the Pages build branch, and redirects web and API requests for the old name, so what's left is the references we hard-code ourselves.The
masterentry in both workflows'branches:filters was only there to keep CI matching across the rename. It matches nothing now, so it goes.gh_edit_branchindocs/_config.ymlis what just-the-docs builds the "Edit this page on GitHub" footer link from, on every docs page. Web redirects cover a stale value for now, but they're not worth relying on long term.The Coveralls badge takes
?branch=mainin both its image and its link. TheTestbadge moves to the per-workflow URL, which accepts abranchparameter, so it reads consistently with the Coveralls badge beside it. This one is a trade-off rather than a straight improvement: the old/workflows/Test/badge.svgform implicitly tracked whatever the default branch happened to be, so it would have survived this rename — and any future one — untouched, where the pinned form won't.Left alone deliberately:
coverallsapp/github-action@masterand theottypes/json1links name branches in other repositories, and GitHub explicitly doesn't redirectuses:refs.Coveralls still has
masteras the project's default branch in its own settings, which we can't change from here, so the coverage badge will read as unknown until a build reports onmain.🤖 Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com