🚚 Point v2's master references at main - #728
Conversation
The default branch is now `main`, but a rename doesn't rewrite files on other branches, and `v2` carries its own copies of the workflows, the README and the docs. This is a straight substitution, with no change in behaviour beyond the rename itself. Only `test.yml`'s filter was doing anything with the old name. A `branches:` filter matches the *base* ref, so the `master` entry covered a PR merging `v2` into the default branch, while the `v2` entry is what covers PRs based on `v2`. That entry is untouched, so CI on this branch is unaffected either way. Two things are deliberately left alone, since neither is caused by the rename and "fixing" either would be a behaviour change: - `docs.yml` lists only the default branch, so `Docs` never runs for pushes to `v2` or PRs based on it. It didn't before this change either, which does mean the docs edits here go unbuilt by CI. - The Coveralls badge and `gh_edit_branch` track the default branch rather than `v2`, so this branch's README reports `main`'s coverage and its docs footer links into `main`. The `Test` badge needs no change, since it names no branch and implicitly follows whatever the default branch happens to be. The `coverallsapp/github-action@master` refs and the `ottypes/json1` link name branches in other repositories, so they stay as they are. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
|
Closing unmerged: not worth touching The change itself was a pure It can't be fixed by pinning Since |
The default branch is now
main, but a rename doesn't rewrite files on other branches, andv2carries its own copies of the workflows, the README and the docs. This is a straight substitution, with no change in behaviour beyond the rename itself.Only
test.yml's filter was doing anything with the old name. Abranches:filter matches the base ref, so themasterentry covered a PR mergingv2into the default branch, while thev2entry is what covers PRs based onv2. That entry is untouched, so CI on this branch is unaffected either way.Two things are deliberately left alone, since neither is caused by the rename and "fixing" either would be a behaviour change:
docs.ymllists only the default branch, soDocsnever runs for pushes tov2or PRs based on it. It didn't before this change either, which does mean the docs edits here go unbuilt by CI.gh_edit_branchtrack the default branch rather thanv2, so this branch's README reportsmain's coverage and its docs footer links intomain.The
Testbadge needs no change, since it names no branch and implicitly follows whatever the default branch happens to be. Thecoverallsapp/github-action@masterrefs and theottypes/json1link name branches in other repositories, so they stay as they are.🤖 Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com