Skip to content

🚚 Point v2's master references at main - #728

Closed
alecgibson wants to merge 1 commit into
v2from
v2-point-master-references-at-main
Closed

🚚 Point v2's master references at main#728
alecgibson wants to merge 1 commit into
v2from
v2-point-master-references-at-main

Conversation

@alecgibson

Copy link
Copy Markdown
Collaborator

The default branch is now main, but a rename doesn't rewrite files on other branches, and v2 carries its own copies of the workflows, the README and the docs. This is a straight substitution, with no change in behaviour beyond the rename itself.

Only test.yml's filter was doing anything with the old name. A branches: filter matches the base ref, so the master entry covered a PR merging v2 into the default branch, while the v2 entry is what covers PRs based on v2. That entry is untouched, so CI on this branch is unaffected either way.

Two things are deliberately left alone, since neither is caused by the rename and "fixing" either would be a behaviour change:

  • docs.yml lists only the default branch, so Docs never runs for pushes to v2 or PRs based on it. It didn't before this change either, which does mean the docs edits here go unbuilt by CI.
  • The Coveralls badge and gh_edit_branch track the default branch rather than v2, so this branch's README reports main's coverage and its docs footer links into main.

The Test badge needs no change, since it names no branch and implicitly follows whatever the default branch happens to be. The coverallsapp/github-action@master refs and the ottypes/json1 link name branches in other repositories, so they stay as they are.

🤖 Generated with Claude Code

Co-Authored-By: Claude noreply@anthropic.com

The default branch is now `main`, but a rename doesn't rewrite files on
other branches, and `v2` carries its own copies of the workflows, the
README and the docs. This is a straight substitution, with no change in
behaviour beyond the rename itself.

Only `test.yml`'s filter was doing anything with the old name. A
`branches:` filter matches the *base* ref, so the `master` entry covered
a PR merging `v2` into the default branch, while the `v2` entry is what
covers PRs based on `v2`. That entry is untouched, so CI on this branch
is unaffected either way.

Two things are deliberately left alone, since neither is caused by the
rename and "fixing" either would be a behaviour change:

 - `docs.yml` lists only the default branch, so `Docs` never runs for
   pushes to `v2` or PRs based on it. It didn't before this change
   either, which does mean the docs edits here go unbuilt by CI.
 - The Coveralls badge and `gh_edit_branch` track the default branch
   rather than `v2`, so this branch's README reports `main`'s coverage
   and its docs footer links into `main`.

The `Test` badge needs no change, since it names no branch and
implicitly follows whatever the default branch happens to be. The
`coverallsapp/github-action@master` refs and the `ottypes/json1` link
name branches in other repositories, so they stay as they are.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@alecgibson

Copy link
Copy Markdown
Collaborator Author

Closing unmerged: not worth touching v2.

The change itself was a pure mastermain substitution following the default branch rename (#727), but it surfaced that v2's Test sharedb-mongo step has been broken since npm 7 began enforcing peer dependencies in mid-2021 — the same point this branch was abandoned.

It can't be fixed by pinning sharedb-mongo to an older tag. The blocker is this branch's own version, 2.0.0-beta.0: npm only matches a prerelease when a comparator carries a prerelease at the same major.minor.patch, and every sharedb-mingo-memory range from 1.0.1 onward is built from stable carets plus ^1.0.0-beta. So a 2.x prerelease satisfies none of them, including via sharedb-mongo@2.1.2/@3.0.0, which both pull sharedb-mingo-memory: ^1.1.1.

Since v2 is dormant, its remaining master references are harmless — GitHub redirects web and API requests for the old branch name, and nothing on this branch is built or published. Leaving it as-is rather than carrying a rename PR that can't go green.

@alecgibson alecgibson closed this Sep 7, 2026
@alecgibson
alecgibson deleted the v2-point-master-references-at-main branch September 7, 2026 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant