Skip to content

fix: Make the workspace-less abstract clients abstract #645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
razor-x merged 1 commit into from
Aug 28, 2026
+20 −2
Merged

fix: Make the workspace-less abstract clients abstract #645

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions seam/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ async def list(
raise NotImplementedError()


class AbstractSeamWithoutWorkspace:
class AbstractSeamWithoutWorkspace(abc.ABC):
wait_for_action_attempt: Optional[Union[bool, Dict[str, float]]]

@abc.abstractmethod
Expand All @@ -145,7 +145,7 @@ def from_personal_access_token(
raise NotImplementedError


class AbstractAsyncSeamWithoutWorkspace:
class AbstractAsyncSeamWithoutWorkspace(abc.ABC):
wait_for_action_attempt: Optional[Union[bool, Dict[str, float]]]

@abc.abstractmethod
Expand Down
18 changes: 18 additions & 0 deletions test/abstract_models_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
import pytest

from seam.models import (
AbstractAsyncSeamWithoutWorkspace,
AbstractSeamWithoutWorkspace,
)


def test_abstract_seam_without_workspace_cannot_be_instantiated():
with pytest.raises(TypeError, match="abstract"):
# pylint: disable-next=abstract-class-instantiated
AbstractSeamWithoutWorkspace("seam_at_token") # type: ignore[abstract]


def test_abstract_async_seam_without_workspace_cannot_be_instantiated():
with pytest.raises(TypeError, match="abstract"):
# pylint: disable-next=abstract-class-instantiated
AbstractAsyncSeamWithoutWorkspace("seam_at_token") # type: ignore[abstract]
Loading