fix: Make the workspace-less abstract clients abstract - #645
Merged
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y1RzepycXEYA3LStfjt8cY
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
AbstractSeamWithoutWorkspaceandAbstractAsyncSeamWithoutWorkspaceused@abc.abstractmethodwithout anABCMetametaclass, so the decorator set__isabstractmethod__and nothing ever read it — both classes were directly instantiable (SDK audit finding L5b). Every other abstract base in the SDK (AbstractSeam,AbstractSeamHttpClient, the workspaces abstracts) already inheritsabc.ABC; these two were the odd ones out.Both now inherit
abc.ABC, making instantiation aTypeErrorlike their siblings.SeamWithoutWorkspace/AsyncSeamWithoutWorkspacesubclass them with concrete implementations, so nothing else changes.Testing
New
test/abstract_models_test.pyasserts direct instantiation of both classes raisesTypeError. Revert check: withseam/models.pyreverted to main, both tests fail (the classes instantiate silently). Full suite: 187 passed; mypy, pylint (10.00), black clean.🤖 Generated with Claude Code
https://claude.ai/code/session_01Y1RzepycXEYA3LStfjt8cY
Generated by Claude Code