Repository navigation
Conversation
--soloCellReadStats takes STAR's value, Standard (CB stays as a deprecated alias), and --genomeChrSetMitochondrial defaults to STAR's chrM M MT. Each feature keeps its own table; region columns come from the feature's own overlap type; every read is counted under cbMatch; one-mismatch and 1MM_multi barcodes are resolved with the run's exact counts, as the matrix resolves them; featureM, countedM, nUMImulti and nGenesMulti are filled. Rows are folded in input order by the in-order consumer. On CellRanger's tiny 10x data every value matches STARsolo 2.7.11b except on the 3 barcodes of 3 reads rustar-aligner maps and STAR leaves unmapped. Row order still differs from STAR's (which was the same at 1 and 8 threads); DIVERGENCE.md 3.2 now says what was measured. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Solo.out/<feature>/CellReads.statsnow carries the values STARsolo writes (SoloReadFeature_record.cpp,SoloReadFeature_inputRecords.cpp,SoloFeature_statsOutput.cpp).--soloCellReadStatstakes STAR's value,Standard.CB, which rustar-aligner took before, stays as a deprecated alias.--genomeChrSetMitochondrialdefaults to STAR'schrM M MTinstead of naming nothing.GeneandGeneFullno longer print the same rows.exonicfor aGeneread with a gene, none forGeneFull), not from CellRanger's positional regions.cbMatchcounts every read, including those whose barcode or UMI was rejected.cbMMunique,cbMMmultipleand the rows match.featureMandcountedMare now filled, andnUMImulti/nGenesMulticome from the first--soloMultiMappersmatrix.Evidence
cargo test: 821 passed, 0 failed.cargo clippy --all-targetsandcargo fmt --checkare clean. New tests are intests/solo_cell_read_stats.rs.tinygex_S1_L001, 230,610 reads), whitelist3M-february-2018,--soloFeatures Gene GeneFull.genomeU+2,genomeM+1, and in GeneFullfeatureM+2).Known divergence: row order
The row order still differs from STAR's. STAR writes these rows by iterating a
std::unordered_mapkeyed by whitelist index. rustar-aligner writes them in reverse order of each barcode's first appearance, which agrees with STAR only on the first rows of this data.STAR's order was the same at 1 and 8 threads. A model of a libc++ hash-table walk did not reproduce it, so what sets STAR's order is not settled.
DIVERGENCE.md§3.2, which previously claimed the orders matched, now records what was measured.The values are the content of the file. Read it by barcode, and sort both files by barcode before comparing them with STAR's.
For reviewers
CHANGELOG.md,DIVERGENCE.mdand the CLI parameter docs are updated.--soloCellReadStats CBstill works, as an alias, for anyone already passing it.🤖 Generated with Claude Code