Repository navigation
Conversation
Clippy 1.100 (rustc 1.100.0, now on CI's stable) adds two lints that fail `cargo clippy --all-targets -- -D warnings` on main: duplicated `#[allow(clippy::too_many_arguments)]` on two SAM record builders, and a range loop indexing `canon_sj` in the chimeric BAM writer. Drop the duplicates and find the mate gap with `position`; behaviour is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Clippy 1.100 (rustc 1.100.0, the current stable on CI) fails
cargo clippy --all-targets -- -D warningsonmainwith three errors:clippy::duplicated_attributes:#[allow(clippy::too_many_arguments)]appears twice onbuild_paired_recordsandbuild_half_mapped_recordsinsrc/io/sam.rs. One copy of each is removed.clippy::needless_range_loop: the loop insrc/chimeric/bam.rsthat finds the first mate gap int.canon_sj. It now usesiter().position(...). The result is the same: the first mate gap gives 2 mates and its index, and no gap gives 1 mate andn_ex - 1.No behaviour change.
Why
Every open PR fails the Clippy check until
mainis clean under the new toolchain, including #378 (Dependabot) and #379.Checked
cargo +1.100.0 clippy --all-targets -- -D warningspasses.cargo fmt --checkpasses.cargo test: 813 passed, 0 failed.🤖 Generated with Claude Code