Repository navigation
Console menus render above cards; invite codes only for invite joiners - #45
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 54 minutes. View limit details
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Grant eligibility and documented rule crates/outer/src/auth/mod.rs, crates/outer/src/auth/tests.rs, web/docs/sign-in.mdx |
Grant-code minting now requires a carried invite and excludes admins. The test and sign-in documentation describe the invite-based rule. |
Console layout
| Layer / File(s) | Summary |
|---|---|
Dropdown placement and stacking web/pages/console/_islands/console.tsx, web/pages/console/console.css |
The account dropdown uses dropdown-end. The rail has z-index: 20, and .drawer-side has z-index: 30 at viewport widths up to 767px. |
Priority:
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Bug fix
Possibly related PRs
- ryuzcorp/outer#37: Adds the console shell containing the account dropdown and rail affected by these layout changes.
Merge Risk: 
Minimal · up to e0538
-
No concrete merge-blocking risk remains.
Pre-merge checks: 
4 · 
1
-
Failed checks: 1 warning Passed checks: 4 passedFull details: Docstring Coverage
-
Explanation
Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 3 files. (2 skipped: 2 unsupported.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
-
Finishing Touches: 💡 2
-
📝 Generate docstrings: 💡
-
- Commit to this branch
- Create a new PR
🛠️ Fix failing CI checks: 💡
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
…to open database file')
Owner: "fix popovers and drop-downs in console, they render behind content cards, invisible" and "app collaborators shouldn't get extra codes".
Menus behind cards. The rail is
position: sticky, which makes it its own stacking context: its daisyUI dropdowns (z-index 999) and tooltips only stack inside it, and the later, positioned cards (.cardisposition: relative) painted over them..railnow hasz-index: 20; on phones the drawer gets 30 so it still covers the rail. The account menu was alsodropdown-right dropdown-top, which hung below the viewport from the bottom avatar; it'sdropdown-right dropdown-endnow (opens upward, aligned to the avatar).Codes only for invite joiners. Grants were minted for every new non-admin account, so anyone admitted through the allowlist (how app collaborators get in) would get 3. Now only accounts that joined with an invite code get them. Test renamed and inverted (
only_invite_joiners_get_grants); the round-trip test still pins 3 for invite joiners. Docs updated.Live (
outer:e0538d5): opened the create popover and the account menu at 1440 and 390 px;elementFromPointinside each lands on the menu itself (was covered before). 458 tests pass.CodeRabbit is out of free reviews; merging on green CI plus the live check.
Summary by CodeRabbit