Skip to content

Console menus render above cards; invite codes only for invite joiners - #45

Merged
ryuzdev merged 3 commits into
mainfrom
console-layers
Oct 24, 2026
Merged

ryuzdev merged 3 commits into
mainfrom
console-layers

Conversation

@ryuzdev

@ryuzdev ryuzdev commented Oct 24, 2026 •

Copy link
Copy Markdown
Member

Owner: "fix popovers and drop-downs in console, they render behind content cards, invisible" and "app collaborators shouldn't get extra codes".

Menus behind cards. The rail is position: sticky, which makes it its own stacking context: its daisyUI dropdowns (z-index 999) and tooltips only stack inside it, and the later, positioned cards (.card is position: relative) painted over them. .rail now has z-index: 20; on phones the drawer gets 30 so it still covers the rail. The account menu was also dropdown-right dropdown-top, which hung below the viewport from the bottom avatar; it's dropdown-right dropdown-end now (opens upward, aligned to the avatar).

Codes only for invite joiners. Grants were minted for every new non-admin account, so anyone admitted through the allowlist (how app collaborators get in) would get 3. Now only accounts that joined with an invite code get them. Test renamed and inverted (only_invite_joiners_get_grants); the round-trip test still pins 3 for invite joiners. Docs updated.

Live (outer:e0538d5): opened the create popover and the account menu at 1440 and 390 px; elementFromPoint inside each lands on the menu itself (was covered before). 458 tests pass.

CodeRabbit is out of free reviews; merging on green CI plus the live check.

Summary by CodeRabbit

  • Behavior Changes
    • Accounts receive three shareable grant codes only when they join using an invite code. Collaborators and allowlisted users who join without one receive none.
  • Bug Fixes
    • Adjusted console account-menu placement and mobile drawer layering for improved display.
  • Documentation
    • Updated sign-in guidance to explain who receives grant codes.

@coderabbitai

coderabbitai Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 54 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: c682b6ed-28ac-4019-af3c-6b2002e26273
Commits

Reviewing files that changed from the base of the PR and between e0538d5 and 18e83fb.

Files selected for processing: 1
  • crates/outer/src/deploy/pipeline.rs

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 7ae2840b-e1eb-471e-9e20-74a52900cafd
Commits

Reviewing files that changed from the base of the PR and between cb493e2 and e0538d5.

Files selected for processing: 5
  • crates/outer/src/auth/mod.rs
  • crates/outer/src/auth/tests.rs
  • web/docs/sign-in.mdx
  • web/pages/console/_islands/console.tsx
  • web/pages/console/console.css

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

New accounts receive grant codes only when they join with a carried invite and are not admins. The sign-in documentation and test reflect this rule. The console account dropdown placement and rail and mobile drawer stacking styles have also changed.

Changes: Invite-based grant codes

Layer / File(s) Summary
Grant eligibility and documented rule
crates/outer/src/auth/mod.rs, crates/outer/src/auth/tests.rs, web/docs/sign-in.mdx
Grant-code minting now requires a carried invite and excludes admins. The test and sign-in documentation describe the invite-based rule.

Console layout

Layer / File(s) Summary
Dropdown placement and stacking
web/pages/console/_islands/console.tsx, web/pages/console/console.css
The account dropdown uses dropdown-end. The rail has z-index: 20, and .drawer-side has z-index: 30 at viewport widths up to 767px.

Priority: Pending latest changes

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Possibly related PRs

  • ryuzcorp/outer#37: Adds the console shell containing the account dropdown and rail affected by these layout changes.
Merge Risk: Minimal · up to e0538

No concrete merge-blocking risk remains.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 3 files. (2 skipped: 2… Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title accurately summarizes the two main changes: console menu layering and invite-code grants for invite joiners. It is specific and concise.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 3 files. (2 skipped: 2 unsupported.)

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

Finishing Touches: 💡 2
📝 Generate docstrings: 💡
  • Commit to this branch
  • Create a new PR
🛠️ Fix failing CI checks: 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ryuzdev
ryuzdev merged commit cc32442 into main Oct 24, 2026
3 of 4 checks passed
@ryuzdev
ryuzdev deleted the console-layers branch October 24, 2026 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant