Skip to content

fix(gateway): apply provider configuration to model conversations - #10

Merged
fffonion merged 7 commits into
masterfrom
fix/gateway-config-chat
Nov 18, 2026
Merged

fffonion merged 7 commits into
masterfrom
fix/gateway-config-chat

Conversation

@fffonion

@fffonion fffonion commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Load gateway model/provider defaults and the operator credential reference before startup, retaining the native HTTPS/auth ownership and cancellation boundary.
  • Deliver buffered final replies to Telegram and preserve tool calls when a Chat response omits content.
  • Return Guardian denials and failed reviews as failed tool observations so the business conversation can continue, without executing the rejected action or weakening approval policy.
  • Carry public tool error details into Chat follow-up messages and keep Guardian assessment turns outside business history.
  • Preserve the selected native tool name in ordinary and managed completion events, fixing Telegram's unknown tool completed status.

Validation

  • 228 distinct related tests passed: 187 production-source regressions plus all 41 managed effect-commit recovery cases. The CI follow-up changes only the obsolete managed denial fixture, retaining zero-effect/no-view checks and adding no-start/business-completion checks; production source remains identical to the live-tested deployment.
  • Formatting, all-target check, all-target Clippy with warnings denied, and gateway build passed.
  • Real Telegram replay of the reported input completed with a named search_files result and a delivered business reply.
  • An explicitly authorized pwd returned exit code 0; its follow-up conversation also completed.
  • A natural greeting exercised a real Guardian denial of a terminal action: that action never started, the run still completed, and the delivered edited reply matched both persisted assistant text and terminal output.
  • Live validation retains the initial pre-model historical-builtin admission failure and a forced-refusal probe that did not request a tool; neither is counted as successful denial coverage. Deployment activated the validated current builtin through the existing native compare-and-swap operation after verifying unchanged declarations, with install administration remaining disabled.

@fffonion
fffonion added this pull request to stack #13 November 18, 2026 13:00
@fffonion
fffonion merged commit 98af75a into master Nov 18, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant