Skip to content

feat(telegram): stream replies, review handoff and API-key lifecycle - #11

Merged
fffonion merged 16 commits into
fix/gateway-config-chatfrom
feat/telegram-typing-edit
Nov 18, 2026
Merged

fffonion merged 16 commits into
fix/gateway-config-chatfrom
feat/telegram-typing-edit

Conversation

@fffonion

@fffonion fffonion commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Non-expiring API-key follow-up: c019ceadbc73ac1d1f02aadf7c18b9ff48a04454

  • Explicit expires_at_ms: 0 means no credential expiration only for canonical stored api-key; OAuth expiry, request deadlines, access/refresh TTL, one-shot use and revocation remain enforced. The generation-checked metadata-only Native CAS has no new guest or HTTP management binding.
  • Product and scoped operator-reconciliation reviews passed. Real synthetic pre-publication and post-publication filesystem-sync failures prove independent readback, indeterminate/non-success handling and no automatic retry.
  • Exact-head original CI, attempt 1, passed all original steps. The default-only release candidate was built and independently byte-bound to the installed and running executable.
  • Deployment completed: one fresh-generation Native CAS changed the existing credential to expiry zero and generation 4; independent readback and secret/metadata/record preservation checks passed. Original model, provider URL, trusted roots and allowlist remain unchanged.
  • Real HTTP provider-only, read_file and same-session reuse passed; every SSE final was independently compared with the same run business final. A separate real file read also passed after removing the build target, execution worktree and lease TEMP. Successful owned fixtures/sessions were removed and read back absent; prior failed operator history remains.
  • Historical local durable target remains 75 passed / 2 waiting-timeout failures; supplemental passes and the new full CI success do not relabel that historical run. No local full-green, warning-free, all-tools, performance or real Telegram owner-acceptance claim.

Summary

  • Stream public assistant replies and tool progress with private transient drafts and group/topic send-and-edit delivery; render final Markdown and readable approval cards.
  • Seal auto once for Telegram admission when no reviewer is configured. Preserve explicit user/guardian and non-Telegram defaults.
  • Let Guardian allow the exact original action once, reject explicit denial/critical risk/authority failures, and hand off only a valid uncertain decision through a durable guardian_pending to human_pending transition.
  • Share exact per-approval manual eligibility across picker publication/binding, callback, slash commands and HTTP resolution. Preserve private-owner previews, group/topic terminal restrictions, cancellation, expiry and restart behavior.
  • Keep private assessments out of business history and public replies. Retain exact message binding, duplicate-review/effect suppression and obsolete-keyboard reclamation.
  • Coordinate duplicate cold compilation through the existing bounded LRU without changing permissions, dependencies or production deadlines.

Automatic-review baseline validation: 7760e4764295f4688141dc554f8e09e57d232c0a

  • Default-concurrency provider_durable_replay_loop_tests: 76 passed, 0 failed, 0 filtered, inner exit 0, 249.91s.
  • Exact critical integration and its negative control: 2 passed, 74 filtered; these are already included in the 76-case full target.
  • Compile-cache module: 7 passed, 731 filtered.
  • Strict Clippy passed with --locked --all-features --lib --tests --bins --profile test -- -D warnings; format and whitespace checks passed.
  • All 478 selected source paths, including Cargo manifest/lock, retained identical bytes/modes/links during each gate and across commit/push. Independent scoped final review accepted the current auto scope.
  • Critical observation is an explicit test-only contract revision: the old 8s whole-run gate, then 8s security plus 12s business gates, are replaced by one shared absolute envelope using the existing 30s fixture run timeout, starting before adapter admission. The 8s admission sub-bound remains. Exact denial/tool-failure identity, zero effects/picker/tool starts, privacy, the real final business denial and deadline-first negative controls remain mandatory. This is not a product deadline increase or a performance/root-cause-fix claim. Historical failing receipts remain preserved.
  • Historical local full-library result 706 passed / 3 failed / 6 ignored remains a separately attributed earlier result; no current green local full-library claim is made.

Stack and CI

Deployment and live qualification

  • The previous presentation release e18917c56c6881dbcf06a99f6b67818afbbb1441 is retained for rollback; its default build and HTTP file-read/session-reuse results retain their original provenance.
  • The automatic-review default release 7760e4764295f4688141dc554f8e09e57d232c0a is installed and restarted with candidate/installed/live executable bytes matched. Gateway and Telegram startup are ready; authenticated health and model listing return 200. A real HTTP-admitted model request fails before native HTTP with access_unavailable: read-only Native metadata confirms an expired local finite access lease, without proving upstream-key expiry. Credentials were not modified or renewed. Current-head real file-read/session-reuse qualification and operator Telegram acceptance remain pending.
  • Earlier real HTTP six-tool/process/cancellation/session-reuse qualification retains its original b263d18 provenance and does not establish current auto behavior.
  • Approval integration coverage uses the production service/persistence with fixture native providers and a loopback Bot API. Real Telegram button acceptance remains an operator check; no live-Telegram PASS is claimed.

@fffonion fffonion changed the title feat(telegram): stream drafts and edit grouped replies feat(telegram): stream replies and add interactive approvals Nov 11, 2026
Seal automatic review for unconfigured Telegram ingress and persist
an exact one-call human handoff only for valid uncertain decisions.
Keep explicit denials, critical risk and authority failures closed.

Cover ownership, restart, cancellation, storage faults and concurrent
resolution. Coordinate duplicate cold compilation through the LRU.
Qualify critical denial and its business final under one shared
original-fixture observation deadline; production deadlines unchanged.
@fffonion fffonion changed the title feat(telegram): stream replies and add interactive approvals feat(telegram): stream replies and add automatic review with human handoff Nov 12, 2026
Recognize zero expiry only for canonical stored API-key credentials.
Keep OAuth expiry, bounded one-shot handles and request ownership intact.
Provide a trusted Native generation-checked metadata update that preserves
secret slots and unrelated records, with default-feature SDK proof.

Focused auth-store suite: 42 passed. Strict Clippy and native header
regressions passed. Historical local durable target remains 75 passed /
2 waiting-timeout failures; its focused pair passed separately.
This publication acquires new-head CI; it does not claim local full green.
@fffonion fffonion changed the title feat(telegram): stream replies and add automatic review with human handoff feat(telegram): stream replies, review handoff and API-key lifecycle Nov 12, 2026
@fffonion
fffonion added this pull request to stack #13 November 18, 2026 13:00
@fffonion
fffonion merged commit 452b627 into master Nov 18, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant