Skip to content

Grammar check: don't require compilation on PRs #2363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
traviscross merged 1 commit into from
Sep 22, 2026
+1 −1
Merged

Grammar check: don't require compilation on PRs #2363

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ jobs:
- name: Verify tools workspace lockfile is current
run: cargo update -p mdbook-spec --locked
- name: Test tools
run: cargo test
run: cargo test --workspace --exclude grammar-check

@traviscross traviscross Sep 22, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit unfortunate to not build-check the other parts of grammar-check that aren't sensitive to rustc churning. Maybe later we could separate this off somehow.

View changes since the review


dev-guide:
name: dev-guide build check
Expand Down
Loading