Grammar check: don't require compilation on PRs - #2363
Merged
traviscross merged 1 commit intoSep 22, 2026
Merged
Conversation
rustbot
added
the
S-waiting-on-review
DanielEScherzer
force-pushed
the
grammar-check-on-pr
branch
from
September 22, 2026 19:40
8056693 to
5767334
Compare
traviscross
reviewed
Sep 22, 2026
| run: cargo update -p mdbook-spec --locked | ||
| - name: Test tools | ||
| run: cargo test | ||
| run: cargo test --workspace --exclude grammar-check |
Contributor
There was a problem hiding this comment.
It's a bit unfortunate to not build-check the other parts of grammar-check that aren't sensitive to rustc churning. Maybe later we could separate this off somehow.
traviscross
approved these changes
Sep 22, 2026
Contributor
|
Thanks @DanielEScherzer. |
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.