fix(client): raise NodeNotFoundError for a node from another JavaScript world

CHANGELOG.md

@@ -5,6 +5,10 @@
 ### Changed
 
 ### Fixed
+- Passing a node resolved on the previous page to `evaluate`, e.g. when the page navigates while Cuprite searches
+  within an element, raised `Ferrum::BrowserError: Argument should belong to the same JavaScript world as target
+  object`. It's `Ferrum::NodeNotFoundError` now, so callers can treat the node as stale and find it again
+  [rubycdp/cuprite#233]
 
 ### Removed
 

lib/ferrum/client.rb

@@ -376,7 +376,8 @@ def raise_browser_error(error)
       # Node has disappeared while we were trying to get it
       when "No node with given id found",
            "Could not find node with given id",
-           "Inspected target navigated or closed"
+           "Inspected target navigated or closed",
+           "Argument should belong to the same JavaScript world as target object"
         raise NodeNotFoundError, error
       # Context is lost, page is reloading
       when "Cannot find context with specified id"

spec/frame/runtime_spec.rb

@@ -236,6 +236,18 @@
 
       expect(elapsed).to be < Ferrum::Frame::Runtime::INTERMITTENT_SLEEP
     end
+
+    it "raises NodeNotFoundError for a node resolved on the previous page" do
+      browser.go_to("/table")
+      node = browser.at_xpath(".//td")
+      object_id = browser.page.command("DOM.resolveNode", nodeId: node.node_id).dig("object", "objectId")
+
+      browser.go_to("/table")
+
+      expect do
+        browser.evaluate("arguments[0].textContent", { "objectId" => object_id })
+      end.to raise_error(Ferrum::NodeNotFoundError, /same JavaScript world/)
+    end
   end
 
   describe "#add_script_tag" do