Repository navigation
fix(client): raise NodeNotFoundError for a node from another JavaScript world - #647
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes rubycdp/cuprite#233.
When the page navigates between resolving a node (
DOM.resolveNode) and evaluating with it, Chrome rejects the call withArgument should belong to the same JavaScript world as target object: the object belongs to the previous page's context. Ferrum raised it as a plainFerrum::BrowserError, so Cuprite couldn't tell the node was stale, and Capybara failedwithin(...) { find(...) }immediately instead of finding the scope again and retrying.It's now raised as
Ferrum::NodeNotFoundError, like the other "node is gone" messages. Cuprite already turns that intoObsoleteNode, which Capybara retries.The spec resolves a node, navigates, then evaluates with the old object. Without the fix it gets
Ferrum::BrowserError.