Repository navigation
Conversation
VDP-4549: replace broad allchannels access with the reserved __sentinel__:hello channel in the Sentinel ACL example.
Explain how forged HELLO messages can redirect Sentinels and expose configured master credentials. Clarify that existing ACLs are unchanged and should be reviewed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to VDP-4549.
Replace the broad
allchannelspermission in the ACL example with access to the reserved__sentinel__:hellochannel, matching the Sentinel security guidance.Note
Low Risk
Documentation-only changes with no runtime or configuration impact.
Overview
Documentation-only update to align Sentinel ACL guidance with least-privilege Pub/Sub access and stronger security warnings (VDP-4549).
In
acl.md, the example SentinelACL SETUSERline no longer usesallchannels; it now usesresetchannels &__sentinel__:helloso the sentinel user can only access the reserved hello channel.In
sentinel.md, the existing__sentinel__:hellowarning is expanded to describe forged HELLO messages (redirecting Sentinels, possible exposure of master credentials, spurious failovers/DoS) and adds explicit ops guidance: the doc change does not fix deployments—operators should review ACL users on monitored nodes, includingdefault, and ensure no non-Sentinel user can publish or subscribe to__sentinel__:hello.Reviewed by Cursor Bugbot for commit ec19100. Bugbot is set up for automated code reviews on this repo. Configure here.