Repository navigation
fix: advance a fixed-time task completed early - #808
Merged
Merged
Conversation
For an RRULE with BY* parts, _next() keeps DTSTART and returns the first occurrence after the completion time. A task completed before its DTSTART thus got that same occurrence back and did not move, in both the "safe" and the "thisandfuture" mode. The occurrence is now looked for after DTSTART in that case, as case 1A of the docstring already said. Fixes #782 Prompt: Fix 782, 799, 598, 795, 805, 806 [python-caldav issues; this commit is #782]. The small ones can share one PR, the bigger ones should probably have separated PRs. (...) Assisted-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>
Completing a recurring all-day task with BY* parts raises TypeError in _next(); noted for later. Prompt: [fix issues found during the review process; this one filed for later] Assisted-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>
tobixen
force-pushed
the
fix/complete-early-782
branch
from
October 20, 2026 07:52
1797223 to
136ebea
Compare
tobixen
added a commit
that referenced
this pull request
Oct 20, 2026
#809 gave extract_conn_params_from_section() its section_name, and plann passes it in PyCalendar/plann#81, so nothing is left of the entry. Prompt: [fix issues found during the review process of merging #808] Assisted-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit message:
Also piggy-backing:
docs: TODO: all-day fixed-time task completion(a known gap found in the review), anddocs: TODO: section name in config errors, which is in #807 too.🤖 Generated with Claude Code