Repository navigation
Section name in config error messages - #809
Merged
Merged
Conversation
extract_conn_params_from_section() named every section "section" in its errors, so plann reported a failing password_command as "of section section". It takes the real name as section_name now, and the test-server lookup passes it too. Prompt: Isn't the search-path decided by calendaring-config? Fix the finding #6. [the review finding that caldav's config errors say "of section section"] Assisted-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>
tobixen
force-pushed
the
section-name-in-errors
branch
from
October 20, 2026 07:48
4fcc31a to
3c4b2c4
Compare
tobixen
added a commit
that referenced
this pull request
Oct 20, 2026
#809 gave extract_conn_params_from_section() its section_name, and plann passes it in PyCalendar/plann#81, so nothing is left of the entry. Prompt: [fix issues found during the review process of merging #808] Assisted-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit message:
plann's open PR PyCalendar/plann#81 passes the section name. The TODO entry for this, on #808 branch, is obsolete once this is merged.