Skip to content

Fix http error reporting and json metadata handling #1351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
hstct wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −1
Draft

Fix http error reporting and json metadata handling #1351

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES/+fixed-error-reporting-and-json-metadata-handling.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fixed python syncs masking HTTP errors as stale metadata and handling native json list values in package metadata
1 change: 1 addition & 0 deletions pulp_python/app/tasks/sync.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,7 @@ async def run(self):
auth=downloader.auth,
proxy=downloader.proxy,
proxy_auth=downloader.proxy_auth,
raise_for_status=True,
)

deferred_download = self.remote.policy != Remote.IMMEDIATE
Expand Down
2 changes: 1 addition & 1 deletion pulp_python/app/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,7 +441,7 @@ def json_to_dict(data):
dictionary: of JSON string

"""
if isinstance(data, dict):
if isinstance(data, (dict, list)):
return data

return json.loads(data)
Expand Down
Loading