Fix http error reporting and json metadata handling - #1351
Draft
hstct wants to merge 1 commit into
Draft
Conversation
Raise on unsuccessful HTTP responses during Bandersnatch requests so errors are reported directly instead of being misclassified as stale metadata. Also allow deserialized json list values when rendering python package metadata.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bandersnatch masks http errors when syncing packages as stale metadata instead of reporting them directly the
raise_for_statusflag will show the actual error like if the package is not here 404, or there is a server side error 5xx. This helps debugging. It also doesn't run into a retry loop but fails fast.The other change allows native json list values to be allowed when rendering python package metadata, an error that previously was masked as stale metadata.