Skip to content

src: print exception thrown during primordial initialization #65991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joyeecheung wants to merge 1 commit into
base: main
Choose a base branch
from
+17 −5
Open

src: print exception thrown during primordial initialization #65991

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 17 additions & 5 deletions src/node_realm.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ using v8::MaybeLocal;
using v8::Object;
using v8::SnapshotCreator;
using v8::String;
using v8::TryCatch;
using v8::Value;

Realm::Realm(Environment* env, v8::Local<v8::Context> context, Kind kind)
Expand Down Expand Up @@ -64,11 +65,22 @@ void Realm::CreateProperties() {
Local<Context> ctx = context();

// Store primordials setup by the per-context script in the environment.
Local<Object> per_context_bindings =
GetPerContextExports(ctx, env_->isolate_data()).ToLocalChecked();
Local<Value> primordials =
per_context_bindings->Get(ctx, env_->primordials_string())
.ToLocalChecked();
TryCatch try_catch(isolate_);
Local<Object> per_context_bindings;
Local<Value> primordials;
if (!GetPerContextExports(ctx, env_->isolate_data())
.ToLocal(&per_context_bindings) ||
!per_context_bindings->Get(ctx, env_->primordials_string())
.ToLocal(&primordials)) {
// In general, this should only throw exceptions during local development
// when there's a temporary bug in the scripts. Print the exception here to
// facilitate debugging.
if (try_catch.HasCaught() && !try_catch.HasTerminated()) {
PrintCaughtException(isolate_, ctx, try_catch);
}
env_->Exit(ExitCode::kBootstrapFailure);
return;
}
CHECK(primordials->IsObject());
set_primordials(primordials.As<Object>());

Expand Down
Loading