Skip to content

test(runtime): pin hidden-commit fixture branch - #1336

Closed
Mrun25 wants to merge 1 commit into
monad-developers:unstablefrom
Mrun25:fix/hidden-commit-fixture-branch
Closed

Mrun25 wants to merge 1 commit into
monad-developers:unstablefrom
Mrun25:fix/hidden-commit-fixture-branch

Conversation

@Mrun25

@Mrun25 Mrun25 commented Oct 28, 2026 •

Copy link
Copy Markdown

Fixes #1321.

Initialize the hidden-unreachable-commit test repository with --initial-branch=master, matching its later checkout. The fixture no longer depends on the host's init.defaultBranch; runtime code is unchanged.

Validation on unstable at 9bd4cc4e72e2aac7f4466a65e6df27814e8022a5:

  • Before the change, the targeted test fails with init.defaultBranch=main: pathspec 'master' did not match any file(s) known to git.
  • After the change, the targeted test passes with main, master and custom-primary defaults. These are per-process Git configuration overrides; no global Git settings were changed.
  • The complete generated-workflow-verifier test file passes all 136 tests with both main and master defaults.
  • The runtime dependency build, test TypeScript compilation, changed-file ESLint and Prettier checks, and git diff --check pass.

Checks ran locally on Linux with Node.js 22.23.4. The complete workspace suite, Bun adapter tests, Podman container, Windows/macOS and hosted CI were not run.

AI assistance was used for investigation, the patch, local checks and this description.

RetriggerView in GreptileConfidence Score: 5/5

The PR appears safe to merge.

Summary

Pins the hidden-commit test repository to master, matching its later checkout.

  • The hidden-commit test always starts on master.

Reviews (1) · Last reviewed commit: "test(runtime): pin hidden-commit fixture..." · Reviewed by Greptile

Copilot AI balanced review requested due to automatic review settings October 28, 2026 04:32
@Mrun25
Mrun25 requested a review from a team as a code owner October 28, 2026 04:32

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@aviggiano

Copy link
Copy Markdown
Collaborator

Thanks but PRs from outside contributors is limited at this time.
Feel free to report issues

@aviggiano aviggiano closed this Oct 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Runtime test assumes a fresh repository's initial branch is master, so it fails wherever init.defaultBranch is main

3 participants