Repository navigation
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Collaborator
|
Thanks but PRs from outside contributors is limited at this time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1248.
Replace C1 controls (U+0080-U+009F), bidirectional embeddings/overrides (U+202A-U+202E) and isolates (U+2066-U+2069) with spaces when normalizing attempt failure text. Existing C0/DEL handling, whitespace collapsing, secret redaction and byte limits stay in place. This changes new normalized messages; it does not rewrite historical ledgers or change their schema.
Add regressions for all 41 code points in the three ranges, both within a message and by itself, while preserving visible accented, Greek, Arabic and supplementary-plane text. An integration test checks persistence, queries and idempotent replay through the actual attempt ledger. The new normalization test fails on the baseline at U+0080.
Validation on unstable at
9bd4cc4e72e2aac7f4466a65e6df27814e8022a5, Linux, Node.js 22.23.4:init.defaultBranch=masteroverride. This branch does not include the separate test(runtime): pin hidden-commit fixture branch #1336 fixture fix.git diff --checkpass.The full workspace suite, Bun adapter tests, Podman container, Windows/macOS and hosted CI were not run.
AI assistance was used for investigation, the patch, local checks and this description.


Confidence Score: 5/5
This PR appears safe to merge.Summary
Expands failure-message normalization to replace C1 controls and the specified bidirectional controls with spaces.
Reviews (1) · Last reviewed commit: "fix(artifacts): normalize C1 and bidi co..." · Reviewed by Greptile