Repository navigation
fix: clear new production dependency advisories - #1326
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 07a81e2319
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "@modelcontextprotocol/sdk": "1.32.0" | ||
| "body-parser": "2.4.0" | ||
| "dompurify": "3.4.17" | ||
| "zod": "4.6.6" |
There was a problem hiding this comment.
Propagate the security pins to generated controllers
These workspace overrides secure only the repository's pnpm installation. When ultrafuzz run provisions the production Smithers controller, operatorControllerProjectRoot writes renderSmithersPackageJson() and installs it independently with npm; that manifest's REQUIRED_SMITHERS_OVERRIDES still contains only Effect pins and directly pins Zod 4.4.3. Consequently, the dependency-advisory gate passes while newly installed workflow controllers retain the vulnerable Zod version and the old cutoff-selected MCP SDK/body-parser/DOMPurify versions. Mirror these fixes into the generated manifest, its resolution cutoff, and the migration path for existing .smithers/package.json files.
Useful? React with 👍 / 👎.
8f5daf9 to
0191667
Compare
0191667 to
8f2e2be
Compare
Summary
Validation
pnpm install --frozen-lockfile --config.optimistic-repeat-install=falsepnpm -w security:dependency-advisories— passes against the live registry with only the repository's preexisting documented exceptionpnpm -w buildnode --test packages/runtime/dist-test/test/operator-npm.test.js— 3 passednode --test packages/runtime/dist-test/test/smithers-package.test.js— 10 passedbun test ./scripts/ci/dependency-advisories.test.ts— 21 passedpnpm -w format:checkand focused Prettier checknpm install --package-lock-only --before=2026-10-25T00:00:00Zresolves MCP SDK 1.32.0, body-parser 2.4.0, DOMPurify 3.4.17, and Zod 4.6.6The pinned npm package currently ships an older Undici copy; its pnpm patch carries the published 6.29.1 files that npm includes in its pruned bundle.


Confidence Score: 5/5
The PR appears safe to merge; no new actionable issues were found.Summary
Updates dependency pins in both the pnpm workspace and the separately installed Smithers controller.
The earlier generated-controller Zod finding is addressed. No new actionable issues were found.
Diagram
%%{init: {'theme': 'neutral'}}%% flowchart TD A[Updated dependency pins] --> B[pnpm workspace install] A --> C[Generated controller manifest] C --> D[npm install with fixed cutoff] E[Recognized older manifest] --> F[Non-force init migration] F --> C G[Patched npm bundle] --> DReviews (3) · Last reviewed commit: "chore: refresh security lockfile after p..." · Reviewed by Greptile