Skip to content

fix(typewriter): prune the journal of a replayed enqueue #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kyscott18 merged 1 commit into from
Oct 26, 2026
Merged

fix(typewriter): prune the journal of a replayed enqueue #80

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions packages/typewriter/src/typewriter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,15 +457,22 @@ export function enqueueMutation(params: {
mutation: EnqueuedMutation;
}): Effect.Effect<ExecuteResult, EvmError> {
return Effect.gen(function* () {
// TODO(kyle) prune the enqueue's journal. Nothing reverts or replays it,
// so it stays in the EVM's journal map for the life of the process.
const enqueueCalldata = encodeEnqueueCalldata(params.mutation);

return yield* params.evm.execute({
const executeResult = yield* params.evm.execute({
from: "0x0000000000000000000000000000000000000000",
to: params.app.address,
data: enqueueCalldata,
});

// The enqueue is already onchain, so a settlement never rewinds it.
if (executeResult.status === "success") {
yield* params.evm.pruneJournals({
journal_ids: [executeResult.journal_id],
});
}

return executeResult;
});
}

Expand Down
Loading