Repository navigation
fix(typewriter): prune the journal of a replayed enqueue - #80
Merged
Merged
Conversation
`enqueueMutation` replays a ForceInclusionQueued log in revm but never pruned the journal that the `execute` created. Nothing reverts or replays an enqueue, since it is already onchain, so each log kept a journal in the EVM for the life of the process. Prune it as soon as the enqueue succeeds. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
enqueueMutationreplays eachForceInclusionQueuedlog in revm withexecute, which creates a journal. Nothing ever reverts or replays an enqueue, because it is already onchain, but the journal was never pruned. Each log kept a journal in the EVM for the life of the process, as the removed TODO noted.This prunes the journal as soon as the enqueue succeeds. The leak was found by the journal assertion in #77, which is being reworked; this splits the fix out so it can land on its own.
Tested:
bun run typecheckandbun run testinpackages/typewriter, and simulation seed0x1.🤖 Generated with Claude Code