Skip to content

Support .sbml model file extension - #249

Merged
cdiener merged 1 commit into
micom-dev:mainfrom
rachybio:fix-sbml-extension-131
Sep 11, 2026
Merged

cdiener merged 1 commit into
micom-dev:mainfrom
rachybio:fix-sbml-extension-131

Conversation

@rachybio

Copy link
Copy Markdown
Contributor

Summary

I tested issue #131 against the current MICOM release (v0.39.1) and confirmed that .sbml files were still not supported by micom.util.load_model().

Attempting to load a .sbml model resulted in:

KeyError: '.sbml'

This PR adds support for the .sbml extension and includes a regression test to ensure it can be loaded correctly.

Changes

  • Added .sbml to MICOM's model reader mapping.
  • Added a regression test for .sbml model loading.

Testing

  • Reproduced the issue on MICOM v0.39.1 before the fix.
  • pytest tests/test_util.py::test_load_sbml_extension -q
  • pytest tests/test_util.py -q

Both tests pass after the fix.

Closes #131

@codecov

codecov Bot commented Sep 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.37%. Comparing base (3bff1ca) to head (81f27ad).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #249   +/-   ##
=======================================
  Coverage   81.37%   81.37%           
=======================================
  Files          39       39           
  Lines        2303     2303           
  Branches      318      318           
=======================================
  Hits         1874     1874           
  Misses        294      294           
  Partials      135      135           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cdiener cdiener left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cdiener
cdiener merged commit bdbba36 into micom-dev:main Sep 11, 2026
9 checks passed
@rachybio
rachybio deleted the fix-sbml-extension-131 branch September 11, 2026 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support the .sbml extensions for SBML files

2 participants