Repository navigation
refactor(core): extract the serve request handler into its own module (AI-assisted) - #12865
Merged
Merged
Conversation
… (AI-assisted)
createServeRequestHandler({outDir, baseUrl, trailingSlash}) receives
explicit args instead of closing over serve() variables, so it can be
unit tested. The handler body is unchanged.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
slorber
added
the
pr: maintenance
|
Caution Review failedAn error occurred during the review process. Please try again later. Walkthrough
Merge Risk:
 |
✅ [V2]
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Size Change: 0 B Total Size: 12.1 MB ℹ️ View Unchanged
|
|
Size Change: 0 B Total Size: 12.1 MB ℹ️ View Unchanged
|
⚡️ Lighthouse report for the deploy preview of this PR
|
This was referenced Nov 5, 2026
This was referenced Nov 6, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Extract the
docusaurus serverequest handler from theserve()closure intoserve/requestHandler.ts, so it can be unit tested.createServeRequestHandler({outDir, baseUrl, trailingSlash})receives explicit args instead of closing over theserve()variables. The handler body moves as is: same redirects, samebaseUrlrewrite, sameserve-handleroptions.The only code difference is that the handler is now
asyncand awaitsserveHandler(), so tests can observe its rejections. No behavior change in production: Node's HTTP server ignores the returned promise, so aserveHandler()rejection still reaches the CLI'sunhandledRejectionhandler, like the floating promise did before.This prepares #12858, which adds the
servetest suite.Test Plan
Ran the same matrix of 162 requests against
docusaurus servebuilt frommainand from this branch: 6baseUrl/trailingSlashconfigs × clean URLs,.html, folders, assets, query strings, encoded paths, paths outside thebaseUrl. The status,Locationand served file are identical, including the 4 encodedcaférequests that crash the server onmainwith the same error log.Test links
Deploy preview: https://deploy-preview-12865--docusaurus-2.netlify.app/
(AI-assisted)
🤖 Generated with Claude Code
Summary by CodeRabbit