Repository navigation
fix(usersrole): give the multipart request ceiling headroom - #261
Conversation
…file max-request-size matched max-file-size exactly, so a 2MB file — itself within the limit — was rejected on the part headers and boundaries carried with it. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
Why
usersrole's
max-request-sizewas the same asmax-file-size(2MB). The multipart request also carries part headers and boundaries, so a file just under 2MB, which is within the file limit, got rejected on the request ceiling. This raisesspring.servlet.multipart.max-request-sizeto 4MB.max-file-sizestays at 2MB, so 2MB is still the largest icon, and the request now has room for the multipart overhead around it.Paired with jdwlabs/deployments#321, which raises the NGINX Gateway Fabric body limit on the usersrole route to
4m. Without that, the gateway returns 413 for any upload over 1MB before it reaches this service. That PR also notes that profile-service, which serves/api/profilesin non, needs the same gateway policy.Cherry-picked from
787f7b178.Verified
commitlint --from origin/main: 0 problems.prettier --checkon the changed file: clean.bash gradlew testinapps/backend/usersrole(the targetnx test usersroleruns, invoked directly because local@nx/gradlegraph creation hung): BUILD SUCCESSFUL, 346 tests, 0 failures, 0 errors, 0 skipped🤖 Generated with Claude Code
Summary by CodeRabbit