Repository navigation
[9.0 parity 1/7] fix(nondet): log float as Map2Check 9.0 does (FLOAT 16, %.9g) - #47
Draft
GuilhermeBn198 wants to merge 1 commit into
Draft
GuilhermeBn198 wants to merge 1 commit into
GuilhermeBn198 wants to merge 1 commit into
Conversation
A float row went out as a DOUBLE (15) printed with %lf. Six fixed decimals print 1e-30 as 0 -- a different input -- and the Map2Check 9.0 test-suite writer copies the value column verbatim into <input>, so the suite does not replay the violation. 9.0 gave float its own type, FLOAT 16, printed with %.9g, which round-trips every f32 (issue #74 of Map2Check). c_float reproduces glibc's %.9g; the test pins it to glibc 2.35 output for 22 bit patterns (subnormals, the extremes, nan/inf with their sign).
This was referenced Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of bringing Map2Check 9.0 (hbgit/Map2Check PR #73) onto the Rust runtime. 9.0 kept fixing the C runtime after the cutover snapshot, and once develop links only this library, those fixes would silently stop applying. Measured on the merged build before any port: 18 of 30 Cover-Error probes confirmed by TestCov against 23 with the C runtime.
What
floatrows ofklee_log.csvareFLOAT16 printed with%.9g, as Map2Check 9.0 writes them (they wereDOUBLE15 with%lf). Six fixed decimals print 1e-30 as 0, a different input, and the 9.0 test-suite writer copies the value column verbatim into<input>.c_floatreproduces glibc's%.9g; the test pins it to glibc 2.35 output for 22 bit patterns (subnormals, extremes, signed nan/inf).Measured
With the Map2Check side (float in the pass's type table): the 5 Floats probes go from 0% TestCov coverage (FAILED claimed, empty or wrong
<input>) to 5/5 confirmed; on the 33 Floats Cover-Error tasks, every FAILED so far is confirmed (17 of the 22 finished; 5 UNKNOWN at 300 s on a loaded host).Tests
cargo test(with and withoutlibfuzzer,wasm) andcargo clippy --all-targets --features libfuzzer,wasmpass; KLEE bitcode builds with rustc 1.72.1.Stack (merge in this order; each PR targets the previous branch):
port/nondet-float→developport/assume-prune→port/nondet-floatport/nondet-types→port/assume-pruneport/afl-zero-tail→port/nondet-typesport/klee-log-cap→port/afl-zero-tailport/seed-replay-log→port/klee-log-capport/check-cstring→port/seed-replay-log(also carries the CHANGELOG entry)Then tag
v1.1.0-rc2and bump the pin in Map2Check (scripts/runtime/*); the Map2Check side is the stack onfeat/9.0-merge-developof hbgit/Map2Check.Before leaving draft: the commits are not signed yet (this repo requires verified signatures). Re-sign with
git rebase --exec "git commit --amend --no-edit -S" developon the top branch and force-push the stack.