Repository navigation
[9.0 parity 9/9] perf(klee): pin nondet values only when they will be formatted - #55
Draft
GuilhermeBn198 wants to merge 1 commit into
Draft
GuilhermeBn198 wants to merge 1 commit into
GuilhermeBn198 wants to merge 1 commit into
Conversation
Under KLEE the nondet log was concretised at the end of every path, one solver query plus one assume per value, though it is written only on a violation (and the JSON report only without a mode). Map2Check 9.0 pins the values only on the violating path. On loop-acceleration/array_3-2 (1024 nondet reads) KLEE completed 1 path in its first phase where the 9.0 C runtime completed 263, and the target 9.0 finds in every run (3/3, ~185 s) was never found (0/3). Pinning only when the log or the report will be formatted: found in 2/2 runs (254 s, 113 s).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while comparing the merged build with Map2Check 9.0 (C runtime) on repeated runs. Brings the KLEE cost per path back in line with 9.0.
What
Under KLEE the nondet log was concretised at the end of every path — one
klee_get_valuequery plus oneklee_assumeper value — although the log is written only on a violation (and the JSON report only when no mode is set). Map2Check 9.0 pins the values only on the violating path (nondet_generate_aux_witness_files). Nowconcretizepins the nondet values only when they will be formatted; memory records are still pinned as before.Measured
loop-acceleration/array_3-2(1024 nondet reads), Cover-Error, 300 s:The remaining gap to 9.0 (9 vs 263 paths in phase 1) is the per-read allocation 9.0 also removed and this stack does not (
non_det_log_tbox returned through the C ABI, see #51).Tests
cargo testand clippy pass; KLEE-only change, exercised end to end above.Stack: after #54; merge order #47 → #55. Commits not signed yet (see #47).