Skip to content

chore(release): v1.4.14 - #101

Merged
FumingPower3925 merged 1 commit into
mainfrom
chore/release-v1.4.14
Sep 27, 2026
Merged

FumingPower3925 merged 1 commit into
mainfrom
chore/release-v1.4.14

Conversation

@FumingPower3925

Copy link
Copy Markdown
Contributor

Summary

Sets the two hand-written release stamps to 1.4.14, so the Release workflow's gate (scripts/check-release-stamps.sh v1.4.14) passes and the workflow can create the v1.4.14 tag at this commit once it is on main.

Changes

  • version.go: fallbackVersion 1.4.13 -> 1.4.14 (what a (devel) or test build reports).
  • README.md: the download example's TAG=v1.4.13 -> TAG=v1.4.14.

Nothing else. The other v1.4.13 mentions in the README are history and stay: the allocation figure was measured on v1.4.13, "from the release after v1.4.13 on" names the first release with SLSA provenance (this one), and "v1.4.13 and earlier" have no attestation.

v1.4.14 carries everything merged since v1.4.13: #70, #71, #72, #73, #74, #75, #77, #78, #79, #80, #81, #82, #83, #84, #90 (fixes #87) and #91 (fixes #85, #86, #88, #89). The release notes list them with the known follow-ups.

Test Plan

  • scripts/check-release-stamps.sh v1.4.14: both stamps ok.
  • scripts/check-release-stamps.sh (the CI form, no argument): the stamps agree.
  • gofmt -l version.go: clean.
  • CI: Lint (runs the stamp check), Test, Integration (live celeris).

No code path changes; version_test.go compares against the fallbackVersion constant, not a literal.

Set both hand-written release stamps to 1.4.14, as
scripts/check-release-stamps.sh requires before the Release workflow
creates the tag:

- version.go: fallbackVersion 1.4.13 -> 1.4.14
- README.md: the download example's TAG=v1.4.13 -> TAG=v1.4.14

The other v1.4.13 mentions in the README are history (the allocation
measurement was taken on v1.4.13; releases up to v1.4.13 carry no
provenance attestation) and stay as they are.
@coderabbitai

coderabbitai Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: goceleris/loadgen/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 1bd207b6-e072-476e-a1bf-703b4aef9fab

📥 Commits

Reviewing files that changed from the base of the PR and between 2d15ee5 and 22836ea.

📒 Files selected for processing (2)
  • README.md
  • version.go
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (8)
  • GitHub Check: Coverage
  • GitHub Check: Benchmarks (CodSpeed walltime, arm64 macro runner)
  • GitHub Check: Integration (live celeris)
  • GitHub Check: Lint
  • GitHub Check: Test
  • GitHub Check: Vulnerability Check
  • GitHub Check: Analyze (actions)
  • GitHub Check: Analyze (go)
🧰 Additional context used
📓 Path-based instructions (2)
fallbackVersion in version.go and the download tag in README.md must agree; the Release workflow refuses to tag while they disagree.

⚙️ CodeRabbit configuration file

Files:

  • version.go
loadgen is the measurement instrument for the celeris benchmark suite: a bug here produces a wrong number that looks like a server result.

⚙️ CodeRabbit configuration file

Files:

  • version.go
🔀 Multi-repo context goceleris/probatorium, goceleris/celeris

Linked repositories findings

goceleris/probatorium

  • go.mod:8 and go.sum:18-19 pin loadgen to v1.4.13. New benchmark runs will continue reporting loadgen_version: v1.4.13 until probatorium repins the dependency; mage_publish.go:360 derives the published version from that pin. [::goceleris/probatorium::]

goceleris/celeris

  • The release checklist explicitly treats loadgen’s version.go fallback stamp as a separate release task, confirming that loadgen versions independently from Celeris (internal/release/checklist.go:104-107). [::goceleris/celeris::]
🔇 Additional comments (2)
version.go (1)

15-15: LGTM!

README.md (1)

418-418: LGTM!


📝 Summary

Summary by CodeRabbit

  • Updates
    • The fallback loadgen version is now 1.4.14.
    • The pre-built binary download example now uses version 1.4.14.

Walkthrough

The fallback loadgen version and the README release-download example change from 1.4.13 to 1.4.14. Build-info version resolution remains unchanged.

Changes

Release version update

Layer / File(s) Summary
Update version references
version.go, README.md
The fallback version and the documented release-download tag change to 1.4.14.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 22836

The fallback version and download example both identify v1.4.14, and the release-stamp checks pass. No actionable merge-blocking risk remains.

Architecture Summary

Architecture risk: 🔵 Low · up to 22836

The change affects 2 systems.

Changed systems: version.go, README.md

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — version.go (service) was modified; 1 changed file maps to changed impact.
  • observed — README.md (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in README.md: The release-download example now uses tag v1.4.14 instead of v1.4.13.
  • observed — Modified behavior in version.go: fallbackVersion changes from 1.4.13 to 1.4.14, changing the version reported when build info provides no usable loadgen module version.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title uses the required Conventional Commit format, chore(release): summary, and accurately describes the release stamp update to v1.4.14.
Description check ✅ Passed The description clearly explains the changes to version.go and README.md, their release purpose, retained historical references, and the test status.
Linked Issues check ✅ Passed Issues #87 and #85 are closed and provide historical context only. They impose no coding requirements on this pull request. The release stamp changes do not need to implement their historical fixes.
Out of Scope Changes check ✅ Passed The pull request changes only the two stated v1.4.14 release stamps: fallbackVersion in version.go and the README download tag. These changes support the release workflow and remain within the sta…
Readme Cluster-Bench Contract ✅ Passed The PR changes only README.md (the release download tag) and version.go (the fallback release value). results.go and cmd/loadgen/main.go are unchanged in the reviewed diff. The Result JSON s…
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Sep 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@FumingPower3925
FumingPower3925 merged commit 9f8993e into main Sep 27, 2026
11 checks passed
@FumingPower3925
FumingPower3925 deleted the chore/release-v1.4.14 branch September 27, 2026 12:28
@codspeed

codspeed Bot commented Sep 27, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 94.41%

⚡ 2 improved benchmarks
❌ 3 regressed benchmarks
✅ 14 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
❌ 256workers 5 ns 6,998 ns -99.93%
❌ 1024workers 19 ns 25,878 ns -99.93%
❌ 64workers 5 ns 6 ns -16.67%
⚡ BenchmarkH2CUpgradeRequest 40.2 µs 35.9 µs +12.1%
⚡ BenchmarkExtractStatusWithTableUpdate 120 ns 108 ns +11.11%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing chore/release-v1.4.14 (22836ea) with main (2d15ee5)

Open in CodSpeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant