Repository navigation
chore(release): v1.4.14 - #101
Conversation
Set both hand-written release stamps to 1.4.14, as scripts/check-release-stamps.sh requires before the Release workflow creates the tag: - version.go: fallbackVersion 1.4.13 -> 1.4.14 - README.md: the download example's TAG=v1.4.13 -> TAG=v1.4.14 The other v1.4.13 mentions in the README are history (the allocation measurement was taken on v1.4.13; releases up to v1.4.13 carry no provenance attestation) and stay as they are.
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: goceleris/loadgen/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review. 📜 Recent review details⏰ Context from checks skipped due to timeout. (8)
🧰 Additional context used📓 Path-based instructions (2)fallbackVersion in version.go and the download tag in README.md must agree; the Release workflow refuses to tag while they disagree.⚙️ CodeRabbit configuration file Files:
loadgen is the measurement instrument for the celeris benchmark suite: a bug here produces a wrong number that looks like a server result.⚙️ CodeRabbit configuration file Files:
🔀 Multi-repo context goceleris/probatorium, goceleris/celerisLinked repositories findingsgoceleris/probatorium
goceleris/celeris
🔇 Additional comments (2)
📝 SummarySummary by CodeRabbit
WalkthroughThe fallback loadgen version and the README release-download example change from 1.4.13 to 1.4.14. Build-info version resolution remains unchanged. ChangesRelease version update
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~2 minutes Change: Other Merge Risk: ⚪ Minimal · up to The fallback version and download example both identify v1.4.14, and the release-stamp checks pass. No actionable merge-blocking risk remains. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 2 systems. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Merging this PR will degrade performance by 94.41%
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing |
Summary
Sets the two hand-written release stamps to 1.4.14, so the Release workflow's gate (
scripts/check-release-stamps.sh v1.4.14) passes and the workflow can create thev1.4.14tag at this commit once it is onmain.Changes
version.go:fallbackVersion1.4.13 -> 1.4.14 (what a(devel)or test build reports).README.md: the download example'sTAG=v1.4.13->TAG=v1.4.14.Nothing else. The other v1.4.13 mentions in the README are history and stay: the allocation figure was measured on v1.4.13, "from the release after v1.4.13 on" names the first release with SLSA provenance (this one), and "v1.4.13 and earlier" have no attestation.
v1.4.14 carries everything merged since v1.4.13: #70, #71, #72, #73, #74, #75, #77, #78, #79, #80, #81, #82, #83, #84, #90 (fixes #87) and #91 (fixes #85, #86, #88, #89). The release notes list them with the known follow-ups.
Test Plan
scripts/check-release-stamps.sh v1.4.14: both stamps ok.scripts/check-release-stamps.sh(the CI form, no argument): the stamps agree.gofmt -l version.go: clean.No code path changes;
version_test.gocompares against thefallbackVersionconstant, not a literal.