Repository navigation
docs: the native engines close a detached connection whose peer takes none of its queued bytes for WriteTimeout - #101
Merged
Conversation
… none of its queued bytes for WriteTimeout (Refs celeris#888 items 36, 37; Refs celeris#884 item 66)
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
goceleris-docs | f44233c | Commit Preview URL Branch Preview URL |
Oct 19 2026, 03:27 PM |
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…em 69; ClientPolicyClose can end a stalled stream earlier; no minimum rate; h2c is not covered yet (Refs celeris#888 items 38, 39; Refs celeris#884 item 69)
…t took, plus the sweep interval (Refs celeris#888 items 38, 39)
… the last byte, plus the sweep interval (Refs celeris#888 items 38, 39)
FumingPower3925
marked this pull request as ready for review
October 19, 2026 15:24
Contributor
Author
|
Merging with every required check green (build, coverage, CodeQL, codecov/patch, Workers Builds). The CodeRabbit review is advisory and had not finished. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows goceleris/celeris (PR for celeris#888 items 38 and 39, celeris#884 item 69, branch
fix/ssenonread-polish; goceleris/celeris#1077): the native engines (epoll, io_uring, adaptive) now close a detached connection (SSE, WebSocket) whose peer takes none of the bytes queued for it forWriteTimeout("no progress forWriteTimeout"), andOnDisconnectruns. This removes the known-gap paragraphs written for celeris#855:sse.md(Server timeouts): the per-engine behaviour of a client that stays connected and reads nothing, as a list; the native engines no longer say "WriteTimeoutandClientPolicyClosedo not yet".ClientPolicyCloseis said to be able to end such a stream earlier, when the queue overflows. Caveats added: no minimum rate, and an h2c stream is not covered yet (celeris#884 item 79).configuration.md: the engine table row forepoll/io_uring/adaptive, the paragraph below it, and the link-list line.streaming.md: the Detach paragraph.websocket.md: one row in the native-vs-std table.Merge after the celeris PR is released, not before: the text describes v1.6.0. This repo has no milestones, so none is set.
Refs goceleris/celeris#888 items 38, 39; Refs goceleris/celeris#884 item 69